-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add SessionPools and Sessions #28047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TimLovellSmith
merged 99 commits into
Azure:release-app-Microsoft.App-2024-02-02-preview
from
yitaopan:20240202p-session-sessionpool
May 2, 2024
Merged
Changes from 98 commits
Commits
Show all changes
99 commits
Select commit
Hold shift + click to select a range
0466f48
Add SessionPools.json and Sessions.json
yitaopan 085975f
Prettier
yitaopan 736b434
Update Sessions Api, move count from query parameter to body
7d24da4
Update Sessions Api, create a specific type for updateEnvVars
yitaopan 3f65002
Merge, resolve conflicts
yitaopan 49b2258
Prettier
yitaopan 7579115
Fix
yitaopan fdf1732
Fix
yitaopan e2083fc
Test
yitaopan 2105658
Test
yitaopan b805a40
Test
yitaopan b89435e
Fix
yitaopan 7b12678
Fix
yitaopan 3012e70
Fix
yitaopan bc39d7f
Fix
yitaopan b7e8cde
Add minWarmPoolSize and update coolDownPeriod
yitaopan 0b7b3df
Fix - add minwarmpoolsize for patch
yitaopan 2ef5f2f
Remove MinWarmPoolSize and add ScaleConfiguration
yitaopan 55ca190
sessionpool to sessionPool
yitaopan be67ed6
Move maxConcurrentSessions into scaleConfiguration
yitaopan 1bd2c71
Update coolDownPeriod to cooldownPeriodInSeconds
yitaopan 64db91e
Merge branch 'release-app-Microsoft.App-2024-02-02-preview' into 2024…
yitaopan 099c7a5
Update example sessionPoolName
yitaopan c5cf899
Fix Sessions UpdateEnvVar example
yitaopan faee932
Fix SessionPool example resources
yitaopan 096e9ee
Merge branch 'release-app-Microsoft.App-2024-02-02-preview' into 2024…
yitaopan 406a733
Remove update session env var api
yitaopan 6d0e7a2
Refactor Session apis
yitaopan d41a1a7
Fix
yitaopan ab78cdf
Fix
yitaopan 0f21f79
Fix
yitaopan c167226
Fix
yitaopan 2695e42
Update to customContainerTemplate
yitaopan a29baf6
Add RunningState and RunningStateDetails for SessionPool
yitaopan 8004066
Make RunningState string
yitaopan 7cb646f
Add enableEgress to sessionPool
yitaopan bdd6ba5
Remove SessionAuthConfiguration from sessions to sessionPools
yitaopan ea32d53
Fix and add node count for session pool
yitaopan 5dcfa90
Fix patch
yitaopan 56a1991
Fix typo
yitaopan 5484024
Fix typo
yitaopan 4b8414b
Merge branch 'release-app-Microsoft.App-2024-02-02-preview' into 2024…
yitaopan d6fa624
Update to v5 commontypes
yitaopan 1bdf67a
Add array identifiers
yitaopan 7c19ebf
Fix more descriptions
yitaopan 0bdc104
Modify generate sessions operationId
yitaopan 548769b
Modify generate sessions operationId
yitaopan e2a629c
Modify generate sessions operationId
yitaopan 1fb6264
Add suppression
yitaopan 62ea325
Remove Sessions connectionString
yitaopan 5e9f510
Update operation id for generate sessions
yitaopan 1e7acb5
Add SessionPoolNameParameter in commondefinitions
yitaopan 8987ec1
generatedat and expiredat
yitaopan b84d8a4
sessionKind to sessionType
yitaopan 3af4938
Remove runningState and runningStateDetails for SessionPool
yitaopan e81d3dc
Fix readonly
yitaopan da899e6
Fix
yitaopan b6c3f6c
Fix
yitaopan 19a6af4
Fix
yitaopan 65ec394
Test
yitaopan bba433a
Remove two supressions
yitaopan 6fd9185
Change boolean to enum
yitaopan 0239396
Fix examples
yitaopan 4403da0
Fix examples
yitaopan 4606920
Temp remove suppression
yitaopan 7b421dc
Fix SessionPools ContainerType
yitaopan 0b6c205
Remove SessionAuthConfiguration
yitaopan 0b42504
Add Suppression back
yitaopan c705b1c
Fix
yitaopan edc90bd
Fix
yitaopan d7d7337
Add constraint to count of generated sessions
yitaopan 372e946
Make Session generation async
yitaopan 052aa40
Fix
yitaopan c82b9d9
Fix
yitaopan e008a08
Fix
yitaopan 69a251d
Fix
yitaopan eeea358
Remove pagable
yitaopan 489cd79
Post to Put
yitaopan b61b6c5
post
yitaopan caff56a
post
yitaopan c35507a
long running post
yitaopan 275a1d7
Fix
yitaopan 9b698a8
Suppression:
yitaopan 4ebdeee
Fix
yitaopan 8b179e9
Fix
yitaopan 093a1a0
Fix
yitaopan 261950f
Fix
yitaopan e5dcea5
Fix
yitaopan 3d18d06
Fix
yitaopan b02872d
Fix
yitaopan da8f917
Fix
yitaopan f5a1cde
Fix
yitaopan d9eab1d
Fix
yitaopan c80b5e4
Remove Sessions Apis
yitaopan 5739186
fix
yitaopan db41f15
fix
yitaopan b042168
fix
yitaopan ad074ac
fix
yitaopan 44d624c
fix
yitaopan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
702 changes: 702 additions & 0 deletions
702
...ification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/SessionPools.json
Large diffs are not rendered by default.
Oops, something went wrong.
150 changes: 150 additions & 0 deletions
150
...anager/Microsoft.App/preview/2024-02-02-preview/examples/SessionPools_CreateOrUpdate.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
| "resourceGroupName": "rg", | ||
| "sessionPoolName": "testsessionpool", | ||
| "api-version": "2024-02-02-preview", | ||
| "sessionPoolEnvelope": { | ||
| "location": "East US", | ||
| "properties": { | ||
| "environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube", | ||
| "poolManagementType": "Dynamic", | ||
| "containerType": "CustomContainer", | ||
| "scaleConfiguration": { | ||
| "maxConcurrentSessions": 500, | ||
| "readySessionInstances": 100 | ||
| }, | ||
| "dynamicPoolConfiguration": { | ||
| "executionType": "Timed", | ||
| "cooldownPeriodInSeconds": 600 | ||
| }, | ||
| "customContainerTemplate": { | ||
| "containers": [ | ||
| { | ||
| "image": "repo/testcontainer:v4", | ||
| "name": "testinitcontainer", | ||
| "resources": { | ||
| "cpu": 0.25, | ||
| "memory": "0.5Gi" | ||
| }, | ||
| "command": [ | ||
| "/bin/sh" | ||
| ], | ||
| "args": [ | ||
| "-c", | ||
| "while true; do echo hello; sleep 10;done" | ||
| ] | ||
| } | ||
| ], | ||
| "ingress": { | ||
| "targetPort": 80 | ||
| } | ||
| }, | ||
| "sessionNetworkConfiguration": { | ||
| "status": "EgressEnabled" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/sessionPools/testsessionpool", | ||
| "name": "testsessionpool", | ||
| "type": "Microsoft.App/sessionPools", | ||
| "location": "East US", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube", | ||
| "poolManagementType": "Dynamic", | ||
| "nodeCount": 1, | ||
| "containerType": "CustomContainer", | ||
| "scaleConfiguration": { | ||
| "maxConcurrentSessions": 500, | ||
| "readySessionInstances": 100 | ||
| }, | ||
| "dynamicPoolConfiguration": { | ||
| "executionType": "Timed", | ||
| "cooldownPeriodInSeconds": 600 | ||
| }, | ||
| "customContainerTemplate": { | ||
| "containers": [ | ||
| { | ||
| "image": "repo/testcontainer:v4", | ||
| "name": "testinitcontainer", | ||
| "resources": { | ||
| "cpu": 0.25, | ||
| "memory": "0.5Gi" | ||
| }, | ||
| "command": [ | ||
| "/bin/sh" | ||
| ], | ||
| "args": [ | ||
| "-c", | ||
| "while true; do echo hello; sleep 10;done" | ||
| ] | ||
| } | ||
| ], | ||
| "ingress": { | ||
| "targetPort": 80 | ||
| } | ||
| }, | ||
| "sessionNetworkConfiguration": { | ||
| "status": "EgressEnabled" | ||
| }, | ||
| "poolManagementEndpoint": "https://testsessionpool.agreeableriver-3d30edf1.eastus.azurecontainerapps.io" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/sessionPools/testsessionpool", | ||
| "name": "testsessionpool", | ||
| "type": "Microsoft.App/sessionPools", | ||
| "location": "East US", | ||
| "properties": { | ||
| "provisioningState": "InProgress", | ||
| "environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube", | ||
| "poolManagementType": "Dynamic", | ||
| "containerType": "CustomContainer", | ||
| "scaleConfiguration": { | ||
| "maxConcurrentSessions": 500, | ||
| "readySessionInstances": 100 | ||
| }, | ||
| "dynamicPoolConfiguration": { | ||
| "executionType": "Timed", | ||
| "cooldownPeriodInSeconds": 600 | ||
| }, | ||
| "customContainerTemplate": { | ||
| "containers": [ | ||
| { | ||
| "image": "repo/testcontainer:v4", | ||
| "name": "testinitcontainer", | ||
| "resources": { | ||
| "cpu": 0.25, | ||
| "memory": "0.5Gi" | ||
| }, | ||
| "command": [ | ||
| "/bin/sh" | ||
| ], | ||
| "args": [ | ||
| "-c", | ||
| "while true; do echo hello; sleep 10;done" | ||
| ] | ||
| } | ||
| ], | ||
| "ingress": { | ||
| "targetPort": 80 | ||
| } | ||
| }, | ||
| "sessionNetworkConfiguration": { | ||
| "status": "EgressEnabled" | ||
| }, | ||
| "poolManagementEndpoint": "https://testsessionpool.agreeableriver-3d30edf1.eastus.azurecontainerapps.io" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
16 changes: 16 additions & 0 deletions
16
...source-manager/Microsoft.App/preview/2024-02-02-preview/examples/SessionPools_Delete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
| "resourceGroupName": "rg", | ||
| "sessionPoolName": "testsessionpool", | ||
| "api-version": "2024-02-02-preview" | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "location": "https://management.azure.com/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/providers/Microsoft.App/locations/eastus/operationResults/amF3YUNvbXBvbmVudHM6OWFiZTM5OGUtY2ZjNi00NGZmLThmODQtNjRiOWJhMTUzZWYy?api-version=2024-02-02-preview" | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
60 changes: 60 additions & 0 deletions
60
.../resource-manager/Microsoft.App/preview/2024-02-02-preview/examples/SessionPools_Get.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
| "resourceGroupName": "rg", | ||
| "sessionPoolName": "testsessionpool", | ||
| "api-version": "2024-02-02-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/sessionPools/testsessionpool", | ||
| "name": "testsessionpool", | ||
| "type": "Microsoft.App/sessionPools", | ||
| "location": "East US", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube", | ||
| "poolManagementType": "Dynamic", | ||
| "containerType": "CustomContainer", | ||
| "nodeCount": 1, | ||
| "scaleConfiguration": { | ||
| "maxConcurrentSessions": 500, | ||
| "readySessionInstances": 100 | ||
| }, | ||
| "dynamicPoolConfiguration": { | ||
| "executionType": "Timed", | ||
| "cooldownPeriodInSeconds": 600 | ||
| }, | ||
| "customContainerTemplate": { | ||
| "containers": [ | ||
| { | ||
| "image": "repo/testcontainer:v4", | ||
| "name": "testinitcontainer", | ||
| "resources": { | ||
| "cpu": 0.25, | ||
| "memory": "0.5Gi" | ||
| }, | ||
| "command": [ | ||
| "/bin/sh" | ||
| ], | ||
| "args": [ | ||
| "-c", | ||
| "while true; do echo hello; sleep 10;done" | ||
| ] | ||
| } | ||
| ], | ||
| "ingress": { | ||
| "targetPort": 80 | ||
| } | ||
| }, | ||
| "sessionNetworkConfiguration": { | ||
| "status": "EgressEnabled" | ||
| }, | ||
| "poolManagementEndpoint": "https://testsessionpool.agreeableriver-3d30edf1.eastus.azurecontainerapps.io" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
64 changes: 64 additions & 0 deletions
64
...r/Microsoft.App/preview/2024-02-02-preview/examples/SessionPools_ListByResourceGroup.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
| "resourceGroupName": "rg", | ||
| "api-version": "2024-02-02-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/sessionPools/testsessionpool", | ||
| "name": "testsessionpool", | ||
| "type": "Microsoft.App/sessionPools", | ||
| "location": "East US", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube", | ||
| "poolManagementType": "Dynamic", | ||
| "containerType": "CustomContainer", | ||
| "nodeCount": 1, | ||
| "scaleConfiguration": { | ||
| "maxConcurrentSessions": 500, | ||
| "readySessionInstances": 100 | ||
| }, | ||
| "dynamicPoolConfiguration": { | ||
| "executionType": "Timed", | ||
| "cooldownPeriodInSeconds": 600 | ||
| }, | ||
| "customContainerTemplate": { | ||
| "containers": [ | ||
| { | ||
| "image": "repo/testcontainer:v4", | ||
| "name": "testinitcontainer", | ||
| "resources": { | ||
| "cpu": 0.25, | ||
| "memory": "0.5Gi" | ||
| }, | ||
| "command": [ | ||
| "/bin/sh" | ||
| ], | ||
| "args": [ | ||
| "-c", | ||
| "while true; do echo hello; sleep 10;done" | ||
| ] | ||
| } | ||
| ], | ||
| "ingress": { | ||
| "targetPort": 80 | ||
| } | ||
| }, | ||
| "sessionNetworkConfiguration": { | ||
| "status": "EgressEnabled" | ||
| }, | ||
| "poolManagementEndpoint": "https://testsessionpool.agreeableriver-3d30edf1.eastus.azurecontainerapps.io" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": null | ||
| } | ||
| } | ||
| } | ||
| } |
63 changes: 63 additions & 0 deletions
63
...er/Microsoft.App/preview/2024-02-02-preview/examples/SessionPools_ListBySubscription.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345", | ||
| "api-version": "2024-02-02-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/sessionPools/testsessionpool", | ||
| "name": "testsessionpool", | ||
| "type": "Microsoft.App/sessionPools", | ||
| "location": "East US", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube", | ||
| "poolManagementType": "Dynamic", | ||
| "containerType": "CustomContainer", | ||
| "nodeCount": 1, | ||
| "scaleConfiguration": { | ||
| "maxConcurrentSessions": 500, | ||
| "readySessionInstances": 100 | ||
| }, | ||
| "dynamicPoolConfiguration": { | ||
| "executionType": "Timed", | ||
| "cooldownPeriodInSeconds": 600 | ||
| }, | ||
| "customContainerTemplate": { | ||
| "containers": [ | ||
| { | ||
| "image": "repo/testcontainer:v4", | ||
| "name": "testinitcontainer", | ||
| "resources": { | ||
| "cpu": 0.25, | ||
| "memory": "0.5Gi" | ||
| }, | ||
| "command": [ | ||
| "/bin/sh" | ||
| ], | ||
| "args": [ | ||
| "-c", | ||
| "while true; do echo hello; sleep 10;done" | ||
| ] | ||
| } | ||
| ], | ||
| "ingress": { | ||
| "targetPort": 80 | ||
| } | ||
| }, | ||
| "sessionNetworkConfiguration": { | ||
| "status": "EgressEnabled" | ||
| }, | ||
| "poolManagementEndpoint": "https://testsessionpool.agreeableriver-3d30edf1.eastus.azurecontainerapps.io" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": null | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.