Skip to content

Ms security insights recommendations api 2024 01 01 preview - arm review fixes #27972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuhumsft merged 30 commits into from
Feb 29, 2024
Merged

Ms security insights recommendations api 2024 01 01 preview - arm review fixes #27972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a1871e8
Added Microsoft.SecurityInsights Recommendations API 2024-01-01-preview
Jan 16, 2024
1ab683f
Merge branch 'dev-Sentinel-securityinsights-Microsoft.SecurityInsight…
itielMaimon Feb 7, 2024
834da46
prettier
itielMaimon Feb 7, 2024
233d2c8
prettier
itielMaimon Feb 7, 2024
09152f2
cr
itielMaimon Feb 12, 2024
437921f
Added back Azure-AsyncOperation header
itielMaimon Feb 13, 2024
2d38d0f
cr
itielMaimon Feb 15, 2024
bbb514a
cr
itielMaimon Feb 15, 2024
48421af
cr
itielMaimon Feb 19, 2024
ec7aae3
cr
itielMaimon Feb 19, 2024
7d88ffb
Updated Recommendation per ARM review
itielMaimon Feb 28, 2024
066ccef
Merge branch 'dev-Sentinel-securityinsights-Microsoft.SecurityInsight…
itielMaimon Feb 28, 2024
a1e1ae7
RecommendationPatch
itielMaimon Feb 28, 2024
7945d84
fixes
itielMaimon Feb 28, 2024
63f9dc6
cr
itielMaimon Feb 29, 2024
7fa3a21
check
itielMaimon Feb 29, 2024
9d83450
try
itielMaimon Feb 29, 2024
b432b9e
try3
itielMaimon Feb 29, 2024
7e14190
h
itielMaimon Feb 29, 2024
ead8236
typo
itielMaimon Feb 29, 2024
9de1278
try
itielMaimon Feb 29, 2024
aa6c4ef
r
itielMaimon Feb 29, 2024
2895cd3
rs
itielMaimon Feb 29, 2024
215be4a
s
itielMaimon Feb 29, 2024
3618f1c
d
itielMaimon Feb 29, 2024
996c993
try fix
itielMaimon Feb 29, 2024
20ac8e1
6
itielMaimon Feb 29, 2024
a1483b9
try
itielMaimon Feb 29, 2024
e2062df
ddd
itielMaimon Feb 29, 2024
5d5c3f8
i
itielMaimon Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions ...source-manager/Microsoft.SecurityInsights/preview/2024-01-01-preview/Recommendations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,23 @@
},
"definitions": {
"Recommendation": {
"type": "object",
"allOf": [
{
"$ref": "../../../common/2.0/types.json#/definitions/ResourceWithEtag"
}
],
"description": "Recommendation object.",
"properties": {
"properties": {
"type": "object",
"$ref": "#/definitions/RecommendationProperties",
"x-ms-client-flatten": true
}
}
},
"RecommendationProperties": {
"description": "Recommendation properties object.",
"properties": {
"recommendationTypeId": {
"description": "Id of the recommendation type.",
Expand Down Expand Up @@ -333,6 +349,15 @@
},
"RecommendationPatch": {
"description": "Recommendation Fields to update.",
"properties": {
"properties": {
"$ref": "#/definitions/RecommendationPatchProperties"
}
},
"type": "object"
},
"RecommendationPatchProperties": {
"description": "Recommendation Fields Properties to update.",
"properties": {
"state": {
"description": "State of the recommendation.",
Expand Down Expand Up @@ -387,9 +412,6 @@
"format": "date-time"
}
},
"required": [
"lastEvaluatedTimeUtc"
],
"type": "object"
}
},
Expand Down
43 changes: 24 additions & 19 deletions ...curityInsights/preview/2024-01-01-preview/examples/recommendations/GetRecommendation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,32 @@
"responses": {
"200": {
"body": {
"recommendationTypeId": "Swagger_Example",
"state": "CompletedBySystem",
"title": "someText",
"description": "someText",
"creationTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastEvaluatedTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastModifiedTimeUtc": "2022-02-19T03:57:31.7964447+00:00",
"suggestions": [
{
"suggestionTypeId": "ThreatIntelligence_Example_Suggestion_Example",
"title": "someText",
"description": "someText",
"action": "someText",
"additionalProperties": {
"someKey": "someValue"
"id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/Recommendations/ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"name": "ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"type": "Microsoft.SecurityInsights/Recommendations",
"properties": {
"recommendationTypeId": "Swagger_Example",
"state": "CompletedBySystem",
"title": "someText",
"description": "someText",
"creationTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastEvaluatedTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastModifiedTimeUtc": "2022-02-19T03:57:31.7964447+00:00",
"suggestions": [
{
"suggestionTypeId": "ThreatIntelligence_Example_Suggestion_Example",
"title": "someText",
"description": "someText",
"action": "someText",
"additionalProperties": {
"someKey": "someValue"
}
}
],
"resourceId": "someId",
"additionalProperties": {
"someKey": "someValue"
}
],
"resourceId": "someId",
"additionalProperties": {
"someKey": "someValue"
}
}
}
Expand Down
43 changes: 24 additions & 19 deletions ...urityInsights/preview/2024-01-01-preview/examples/recommendations/GetRecommendations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,32 @@
"body": {
"value": [
{
"recommendationTypeId": "ThreatIntelligence_Example",
"state": "CompletedBySystem",
"title": "someText",
"description": "someText",
"creationTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastEvaluatedTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastModifiedTimeUtc": "2022-02-19T03:57:31.7964447+00:00",
"suggestions": [
{
"suggestionTypeId": "ThreatIntelligence_Example_Suggestion_Example",
"title": "someText",
"description": "someText",
"action": "someText",
"additionalProperties": {
"someKey": "someValue"
"id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/Recommendations/ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"name": "ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"type": "Microsoft.SecurityInsights/Recommendations",
"properties": {
"recommendationTypeId": "ThreatIntelligence_Example",
"state": "CompletedBySystem",
"title": "someText",
"description": "someText",
"creationTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastEvaluatedTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastModifiedTimeUtc": "2022-02-19T03:57:31.7964447+00:00",
"suggestions": [
{
"suggestionTypeId": "ThreatIntelligence_Example_Suggestion_Example",
"title": "someText",
"description": "someText",
"action": "someText",
"additionalProperties": {
"someKey": "someValue"
}
}
],
"resourceId": "someId",
"additionalProperties": {
"someKey": "someValue"
}
],
"resourceId": "someId",
"additionalProperties": {
"someKey": "someValue"
}
}
]
Expand Down
47 changes: 27 additions & 20 deletions ...rityInsights/preview/2024-01-01-preview/examples/recommendations/PatchRecommendation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,33 +6,40 @@
"workspaceName": "myWorkspace",
"recommendationId": "6d4b54eb-8684-4aa3-a156-3aa37b8014bc",
"recommendationPatch": {
"state": "Active"
"properties": {
"state": "Active"
}
}
},
"responses": {
"200": {
"body": {
"recommendationTypeId": "ThreatIntelligence_Example",
"state": "CompletedByUser",
"title": "someText",
"description": "someText",
"creationTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastEvaluatedTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastModifiedTimeUtc": "2022-02-19T03:57:31.7964447+00:00",
"suggestions": [
{
"suggestionTypeId": "ThreatIntelligence_Example_Suggestion_Example",
"title": "someText",
"description": "someText",
"action": "someText",
"additionalProperties": {
"someKey": "someValue"
"id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/Recommendations/ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"name": "ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"type": "Microsoft.SecurityInsights/Recommendations",
"properties": {
"recommendationTypeId": "ThreatIntelligence_Example",
"state": "CompletedByUser",
"title": "someText",
"description": "someText",
"creationTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastEvaluatedTimeUtc": "2022-02-19T03:09:03.4888396+00:00",
"lastModifiedTimeUtc": "2022-02-19T03:57:31.7964447+00:00",
"suggestions": [
{
"suggestionTypeId": "ThreatIntelligence_Example_Suggestion_Example",
"title": "someText",
"description": "someText",
"action": "someText",
"additionalProperties": {
"someKey": "someValue"
}
}
],
"resourceId": "someId",
"additionalProperties": {
"someKey": "someValue"
}
],
"resourceId": "someId",
"additionalProperties": {
"someKey": "someValue"
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion ...nsights/preview/2024-01-01-preview/examples/recommendations/ReevaluateRecommendation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@
"responses": {
"200": {
"body": {
"lastEvaluatedTimeUtc": "2023-10-10T03:09:03.4888396+00:00"
"id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/Recommendations/ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"name": "ceea048e-923e-4eeb-8fcb-6cb0c06b101f",
"type": "Microsoft.SecurityInsights/Recommendations",
"properties": {
"lastEvaluatedTimeUtc": "2023-10-10T03:09:03.4888396+00:00"
}
}
}
}
Expand Down