Skip to content

Adding Detector Endpoints for Web Apps and App Service Environments #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jianghaolu merged 7 commits into from
Apr 16, 2018
Merged

Adding Detector Endpoints for Web Apps and App Service Environments #2764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
010e425
Adding new detector endpoint
stevenernst131 Mar 28, 2018
fc77347
Adding richer descriptions
stevenernst131 Mar 29, 2018
4ea600f
Adding Examples
stevenernst131 Apr 2, 2018
1e66b0c
Remove value and make data set array
stevenernst131 Apr 3, 2018
5710401
Fixing Issues
stevenernst131 Apr 3, 2018
05d0cc0
Undoing Error Response Change
stevenernst131 Apr 6, 2018
9e43026
Removing Default Sections
stevenernst131 Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/Diagnostics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,9 +1681,13 @@
"description": "metadata for the detector"
},
"dataset": {
"$ref": "#/definitions/DiagnosticData",
"description": "Data Set"
"type": "array",
"description": "Data Set",
"items": {
"$ref": "#/definitions/Solution"
Copy link
Contributor

@jianghaolu jianghaolu Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the item type from DiagnosticData to Solution?

Copy link
Contributor Author

@stevenernst131 stevenernst131 Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste error, corrected.

}
}

},
"x-ms-client-flatten": true
}
Expand Down
238 changes: 118 additions & 120 deletions ...manager/Microsoft.Web/stable/2016-03-01/examples/Diagnostics_GetSiteDetectorResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,129 +9,127 @@
"responses": {
"200": {
"body": {
"value": {
"id": "/subscriptions/ef90e930-9d7f-4a60-8a99-748e0eea69de/resourceGroups/Build2015DemoRG/providers/Microsoft.Web/sites/BuggyBakery/detectors/runtimeavailability",
"name": "runtimeavailability",
"location": "West US",
"properties": {
"metadata": {
"description": "This detector analyzes the requests to your application.",
"category": "Availability and Performance",
"subCategory": "Web App Down",
"supportTopicId": ""
},
"dataset": [
{
"table": {
"tableName": "Table_0",
"columns": [
{
"columnName": "PreciseTimeStamp",
"dataType": "DateTime",
"columnType": "datetime"
},
{
"columnName": "count_Http2xx",
"dataType": "Int64",
"columnType": "long"
},
{
"columnName": "count_Http3xx",
"dataType": "Int64",
"columnType": "long"
},
{
"columnName": "count_Http4xx",
"dataType": "Int64",
"columnType": "long"
},
{
"columnName": "count_Http5xx",
"dataType": "Int64",
"columnType": "long"
}
"id": "/subscriptions/ef90e930-9d7f-4a60-8a99-748e0eea69de/resourceGroups/Build2015DemoRG/providers/Microsoft.Web/sites/BuggyBakery/detectors/runtimeavailability",
"name": "runtimeavailability",
"location": "West US",
Copy link
Contributor

@jianghaolu jianghaolu Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"location" is not allowed for a proxy resource.

Copy link
Contributor Author

@stevenernst131 stevenernst131 Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

"properties": {
"metadata": {
"description": "This detector analyzes the requests to your application.",
"category": "Availability and Performance",
"subCategory": "Web App Down",
"supportTopicId": ""
},
"dataset": [
{
"table": {
"tableName": "Table_0",
"columns": [
{
"columnName": "PreciseTimeStamp",
"dataType": "DateTime",
"columnType": "datetime"
},
{
"columnName": "count_Http2xx",
"dataType": "Int64",
"columnType": "long"
},
{
"columnName": "count_Http3xx",
"dataType": "Int64",
"columnType": "long"
},
{
"columnName": "count_Http4xx",
"dataType": "Int64",
"columnType": "long"
},
{
"columnName": "count_Http5xx",
"dataType": "Int64",
"columnType": "long"
}
],
"rows": [
[
"2018-03-27T00:25:00Z",
"772705",
"0",
"0",
"0"
],
"rows": [
[
"2018-03-27T00:25:00Z",
"772705",
"0",
"0",
"0"
],
[
"2018-03-27T00:30:00Z",
"787069",
"0",
"0",
"0"
],
[
"2018-03-27T00:35:00Z",
"781627",
"0",
"1",
"0"
],
[
"2018-03-27T00:40:00Z",
"785017",
"0",
"0",
"0"
],
[
"2018-03-27T00:45:00Z",
"783518",
"0",
"0",
"0"
],
[
"2018-03-27T00:50:00Z",
"785783",
"0",
"0",
"0"
],
[
"2018-03-27T00:55:00Z",
"772874",
"0",
"0",
"0"
],
[
"2018-03-27T01:00:00Z",
"787162",
"0",
"0",
"0"
],
[
"2018-03-27T01:05:00Z",
"782036",
"0",
"0",
"0"
],
[
"2018-03-27T01:10:00Z",
"784642",
"0",
"0",
"0"
]
[
"2018-03-27T00:30:00Z",
"787069",
"0",
"0",
"0"
],
[
"2018-03-27T00:35:00Z",
"781627",
"0",
"1",
"0"
],
[
"2018-03-27T00:40:00Z",
"785017",
"0",
"0",
"0"
],
[
"2018-03-27T00:45:00Z",
"783518",
"0",
"0",
"0"
],
[
"2018-03-27T00:50:00Z",
"785783",
"0",
"0",
"0"
],
[
"2018-03-27T00:55:00Z",
"772874",
"0",
"0",
"0"
],
[
"2018-03-27T01:00:00Z",
"787162",
"0",
"0",
"0"
],
[
"2018-03-27T01:05:00Z",
"782036",
"0",
"0",
"0"
],
[
"2018-03-27T01:10:00Z",
"784642",
"0",
"0",
"0"
]
},
"renderingProperties": {
"renderingType": 2,
"title": "Requests by Status Code",
"description": "This detector breaks down the number of requests that your app received for each status code."
}
]
},
"renderingProperties": {
"renderingType": 2,
"title": "Requests by Status Code",
"description": "This detector breaks down the number of requests that your app received for each status code."
}
]
}
}
]
}
}
}
Expand Down
Loading