Skip to content

NetworkWatcher: Added new parameters to QueryConnectionMonitorResult and ConnectivityCheckRequest #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johannes Bader (olydis) merged 8 commits into from
Mar 30, 2018
Merged

NetworkWatcher: Added new parameters to QueryConnectionMonitorResult and ConnectivityCheckRequest #2763

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a71c92f
Updated examples for network watcher
irrogozh Feb 16, 2018
534e121
Updated api version in network watcher swagger and examples
irrogozh Feb 16, 2018
1fb0844
Fixed Linter errors
irrogozh Feb 16, 2018
6a2b7a0
Fixed Linter errors: iteration 2
irrogozh Feb 16, 2018
a0cdb78
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
irrogozh Mar 28, 2018
21568d4
NetworkWatcher: Added new parameters to QueryConnectionMonitorResult …
irrogozh Mar 28, 2018
e374ea2
NetworkWatcher: Fixed typo
irrogozh Mar 28, 2018
72acce7
Fixed casing for HTTPConfiguration property
irrogozh Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...er/Microsoft.Network/stable/2018-02-01/examples/NetworkWatcherConnectionMonitorQuery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"responses" : {
"200" : {
"body" : {
"sourceStatus": "Active",
"states" : [
{
"connectionState" : "Reachable",
Expand Down Expand Up @@ -41,6 +42,7 @@
},
"202" : {
"body" : {
"sourceStatus": "Active",
"states" : [
{
"connectionState" : "Reachable",
Expand Down
83 changes: 82 additions & 1 deletion ...fication/network/resource-manager/Microsoft.Network/stable/2018-02-01/networkWatcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,7 +1697,7 @@
"UDP"
],
"x-ms-enum": {
"name": "Protocol",
"name": "IpFlowProtocol",

@olydis Johannes Bader (olydis) Mar 30, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change 1

"modelAsString": true
},
"description": "Protocol to be verified on."
Expand Down Expand Up @@ -2307,6 +2307,23 @@
},
"destination": {
"$ref": "#/definitions/ConnectivityDestination"
},
"protocol": {
"type": "string",
"description": "Network protocol.",
"enum": [
"Tcp",
"Http",
"Https",
"Icmp"
],
"x-ms-enum": {
"name": "Protocol",
"modelAsString": true
}
},
"protocolConfiguration": {
"$ref": "#/definitions/ProtocolConfiguration"
}
}
},
Expand Down Expand Up @@ -2504,6 +2521,57 @@
"type": "string"
}
},
"ProtocolConfiguration": {
"description": "Configuration of the protocol.",
"properties": {
"hTTPConfiguration": {

@MikhailTryakhov Mikhail (MikhailTryakhov) Mar 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is hTTP case expected?

@irrogozh irrogozh Mar 29, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

"$ref": "#/definitions/HTTPConfiguration"
}
}
},
"HTTPConfiguration": {
"properties": {
"method": {
"type": "string",
"description": "HTTP method.",
"enum": [
"Get"
],
"x-ms-enum": {
"name": "HTTPMethod",
"modelAsString": true
}
},
"headers": {
"type": "array",
"description": "List of HTTP headers.",
"items": {
"$ref": "#/definitions/HTTPHeader"
}
},
"validStatusCodes": {
"type": "array",
"items": {
"type": "integer"
},
"description": "Valid status codes."
}
},
"description": "HTTP configuration of the connectivity check."
},
"HTTPHeader": {
"properties": {
"name": {
"type": "string",
"description": "The name in HTTP header."
},
"value": {
"type": "string",
"description": "The value in HTTP header."
}
},
"description": "Describes the HTTP header."
},
"AzureReachabilityReportParameters": {
"properties": {
"providerLocation": {
Expand Down Expand Up @@ -2890,6 +2958,19 @@
},
"ConnectionMonitorQueryResult": {
"properties": {
"sourceStatus": {

@olydis Johannes Bader (olydis) Mar 30, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change 2 (constructor signature)

"type": "string",
"enum": [
"Uknown",
"Active",
"Inactive"
],
"x-ms-enum": {
"name": "ConnectionMonitorSourceStatus",
"modelAsString": true
},
"description": "Status of connection monitor source."
},
"states": {
"type": "array",
"items": {
Expand Down