Skip to content

Fix - DataMigration assigns a single discriminator value to multiple model types#2760

Merged
hitenjava merged 1 commit intoAzure:masterfrom
hitenjava:master
Mar 28, 2018
Merged

Fix - DataMigration assigns a single discriminator value to multiple model types#2760
hitenjava merged 1 commit intoAzure:masterfrom
hitenjava:master

Conversation

@hitenjava
Copy link
Member

@hitenjava hitenjava commented Mar 27, 2018

This is to resolve - #2728

The model hierarchy looks like this right now:

> TaskOutput.MigrateSqlServerSqlDbTaskOutput.MigrateSqlServerSqlDbTaskOutputError: ErrorOutput
> TaskOutput.MigrateSqlServerSqlMITaskOutput.MigrateSqlServerSqlMITaskOutputError: ErrorOutput

For a given discriminator name (such as TaskOutput.MigrateSqlServerSqlDbTaskOutput.MigrateSqlServerSqlDbTaskOutputError), all of the possible values (such as ErrorOutput) must be distinct.
Please change the discriminator values to DbErrorOutput and MIErrorOutput, or whatever values you prefer, as long as they are distinct.

Instead of changing the discriminator, removing the common base class so that the discriminator values do not apply for the same object.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2071

@hitenjava hitenjava changed the title Remove TaskOutput base object. Fix - DataMigration assigns a single discriminator value to multiple model types Mar 27, 2018
@AutorestCI
Copy link

AutorestCI commented Mar 27, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1457

Copy link
Contributor

@olydis olydis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitenjava hitenjava merged commit c31daf2 into Azure:master Mar 28, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* Create FeatureConfigurationPOST.json

* Update FeatureConfigurations.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments