Rename retention policy APIs#27593
Merged
LuChen-Microsoft merged 1 commit intojimchou/ms-communication-chat-2024-03-15-previewfrom Jan 30, 2024
Merged
Rename retention policy APIs#27593LuChen-Microsoft merged 1 commit intojimchou/ms-communication-chat-2024-03-15-previewfrom
LuChen-Microsoft merged 1 commit intojimchou/ms-communication-chat-2024-03-15-previewfrom
Conversation
LuChen-Microsoft
requested review from
bexxx and
vicancy
and removed request for
a team
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| communicationserviceschat.json | 2024-03-15-preview(8105fb8) | 2023-11-07(main) |
| communicationserviceschat.json | 2024-03-15-preview(8105fb8) | 2023-11-15-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version does not support 'application/merge-patch+json' as a request body format. New: Chat/preview/2024-03-15-preview/communicationserviceschat.json#L1132:9 Old: Chat/preview/2023-11-15-preview/communicationserviceschat.json#L1132:9 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
jimchou-dev
approved these changes
Jan 30, 2024
LuChen-Microsoft
merged commit fac4ae6
into
jimchou/ms-communication-chat-2024-03-15-preview
ms-zhenhua
pushed a commit
that referenced
this pull request
Mar 21, 2024
…#27225) * add new API version with image upload API's * fix lint issue * add new api version to readme * add name property to UploadChatImageResponse * fix typo * add data retention to 2024-03-15-preview (#27537) * rename UploadChatImageResponse to Result * minor change in wording for startTIme description * resolve PR comments * remove description from x-ms-enum because CI error * resolve review comments * remove un-used definition * rename retention policy apis (#27593) * resolve CI issue * resolve PR comments * fix typo * fix model validation * move incorrectly placed imageViewType * add MicrosoftTeamsAppIdentifierModel --------- Co-authored-by: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the class/base class based on Azure DevEx Architecture Board review.
This swagger version is not implemented/implemented yet. There's no breaking change.
Rename:
base class name: RetentionPolicy -> ChatRetentionPolicy
property name: daysAfterCreation -> deleteThreadAfterDays
discriminator: policyType -> kind