[Azure Load Testing] Onboarding to TypeSpec for control plane GA APIs #27565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the diff for put and patch operation * Change LoadTestAdministrationOperations to LoadTestAdministration to align with the swagger LoadTestAdministration_ prefix Change LoadTestRunOperations to LoadTestRun to align with the swagger LoadTestRun_ prefix
* Update the projected name * Renamed * update config file * update folder * Remove client.tsp * Update the projected name to old ones * Adjust the positions * Update client.tsp * Update tspconfig.yaml Added correct options for python emitter. * Update the metadata * Change the projectedName to client.tsp * Remove the projectedName in routes.tsp * update file * Update the .Net config * Remove the projectedName change for load testing * Revert position change * Update specification/loadtestservice/LoadTestService/tspconfig.yaml --------- Co-authored-by: Ray Chen <[email protected]>
…into feature/loadtesting
* python config * Update client.tsp
* java config * project for java * metricNamespace is required * aggregation is optional * body is optional * metricName and timespan is required
|
@Himanshu49 Typespec validation is failing, can you run the tsv command locally and fix any errors that show up? |
…ub.com/Himanshu49/azure-rest-api-specs into feature/loadtesting-ControlPlane-draft
…Properties model in Azure.ResourceManager.Foundations
markcowl
approved these changes
Apr 2, 2024
krisnaray
approved these changes
Apr 3, 2024
wiboris
pushed a commit
to wiboris/azure-rest-api-specs
that referenced
this pull request
May 7, 2024
…Azure#27565) * initial tsp * client.tsp * client.tsp improvements * model updates * update routes * update implementation * Sync typespec and swagger change for loadtesting service (Azure#24412) * Update the diff for put and patch operation * Change LoadTestAdministrationOperations to LoadTestAdministration to align with the swagger LoadTestAdministration_ prefix Change LoadTestRunOperations to LoadTestRun to align with the swagger LoadTestRun_ prefix * update models * add list metric dimensions op and fix create test run * update client.tsp * fix DimensionValueList and update TestRun model * Configuration changes for LoadTesting (Azure#24481) * Update the projected name * Renamed * update config file * update folder * Remove client.tsp * Update the projected name to old ones * Adjust the positions * Update client.tsp * Update tspconfig.yaml Added correct options for python emitter. * Update the metadata * Change the projectedName to client.tsp * Remove the projectedName in routes.tsp * update file * Update the .Net config * Remove the projectedName change for load testing * Revert position change * Update specification/loadtestservice/LoadTestService/tspconfig.yaml --------- Co-authored-by: Ray Chen <[email protected]> * update routes to be more accurate * update client.tsp for python * python config to avoid breaking (Azure#24801) * python config * Update client.tsp * java, feature/loadtesting, match tsp and swagger (Azure#24878) * java config * project for java * metricNamespace is required * aggregation is optional * body is optional * metricName and timespan is required * Changes for 2023-04-01-preview version * Minor refactoring * Added URL based changes and versioning support (versioning not working) * Versioning support changes * Refactoring * Refactoring * config changes * Added examples and few refactoring * Adding emitters for pythin, ts and csharp * Updated description for timespan field * Update tspconfig as validation pipelines failing. * Rename createOrUpdateTest.json to CreateOrUpdateTest.json * Rename createOrUpdateTestRun.json to CreateOrUpdateTestRun.json * Rename createOrUpdateTest.json to CreateOrUpdateTest.json * Rename createOrUpdateTestRun.json to CreateOrUpdateTestRun.json * suppress warning in client.tsp * Updated examples for stable version * Updated examples based on latest changes * Updated spec for 2023-04-01-preview * Added description for APIVersions model * Updated readme and added examples * removed tsp-output folder and files in it * Updated service name in client * Updated api version parameter * Pushing updated json * Removing unused example file * suppressing warnings in client.tsp * Changes to use standard templates for operations * Changing create and update to generic template as it is changing to default resource parameter. * Updating visibility of FileName * Minor change in name * changes in visibility of filename * Change in model name of fileInfo * Changing file info to testfileinfo * Updated jsons * Changes to rectify warning in pipeline * changing metricName to metricname * Updated examples to revert to metricname * Ran tsp format and update example for metricname parameter * Added query parameter for list test and testrun operation * Updated description * Enable linter rules * Updated description of models and operations * Updated specs after internal review of APIs * Added ContainerInfo in 2023-04-01-preview * Updated operation id for stop test run * Updated operation id for stop test run * Updated default values of properties * Description changes for few properties and models * Addressed errors in breaking change pipeline * Removed unused models, refactored code, addressed PR comments * nit: changes in client and model tsp * spec after nit changes * Changes suggested in API review * Update specification/loadtestservice/LoadTestService/client.tsp Co-authored-by: Timothee Guerin <[email protected]> * Initial draft for control plane spec using TypeSpec * Suggested changes in API review * updating name and description for ContainerInfo * Added publicIPDisabled property to Test and TestRun model in 2023-04-01-preview version * Update properties in examples JSON files * Linting changes * Adding outbound and checkAvailability APIs * Added outboundNetworkDependenciesEndpoint and checkAvailability operations * Removed example tag and related imports * Minor linting * Merge main and changes after run npx command in local * Refactoring code * Addressing PR comments * Changes based on diff with existing swagger * nit * nit changes after merge * Added extension x-ms-parameter-location to loadTestName parameter * Resolved outboundNetworkDependenciesEndpoints API * Added examples to directory * minor changes based on pipeline validation failure * Fixing CI failures in PR * fixed LoadTestResourcePatchRequestBody * Changes to remove unwanted headers * Fixing required properties * Fixing CI failures * Fixing CI errors * Removed retry-after header from responses * Removing breaking changes * Fixing CI errors on PR * Resolving SDK breaking changes * Making value as optional in list response * linting by npx tsv * Changes based on PR comments * Removing breaking changes * Removed duplicate Resource model issue * Addressing PR comments * Updated model and routes to use templates and go for breaking changes in "value" making it required. * Updating location parameter to be used as common-types * removed 200 response for delete * Addressed PR comments, removed duplication of standard models * nit: addressing PR comments * removed @azure-tools/typespec-providerhub * update after npx tsv * Create sdk-suppressions.yaml * add azure-sdk-for-go suppression * Update sdk-suppressions.yaml * nit: json updated * nit: tsp compile * Addressed PR comments. Changed common type version from v5 to v3 * Using version v5 for common types due to warning from ManagedIdentityProperties model in Azure.ResourceManager.Foundations --------- Co-authored-by: Catalina Peralta <[email protected]> Co-authored-by: Mary Gao <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Himanshu Bisht <[email protected]> Co-authored-by: Timothee Guerin <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]>
MaryGao
reviewed
Jul 23, 2024
|
|
||
| #suppress "@azure-tools/typespec-azure-core/no-nullable" "We need resourceId to be nullable." | ||
| @doc("User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/fa5fc227-a624-475e-b696-cdd604c735bc/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.") | ||
| resourceId?: string | null; |
There was a problem hiding this comment.
Can I confirm this value would be allowed with null in the back end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.