Skip to content

[Fleet][UpdateRun] Rename skip target #27449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zman-ms merged 4 commits into from
Jan 19, 2024
Merged

[Fleet][UpdateRun] Rename skip target #27449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4048288
rename skip target
zman-ms Jan 18, 2024
2e80b0e
identifier
zman-ms Jan 18, 2024
6ac9d1e
fix examples
zman-ms Jan 18, 2024
413d86e
format
zman-ms Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...cation/containerservice/Fleet.Management/examples/2024-02-02-preview/UpdateRuns_Skip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
"targets": [
{
"type": "Member",
"target": "member-one"
"name": "member-one"
},
{
"type": "AfterStageWait",
"target": "stage1"
"name": "stage1"
}
]
}
Expand Down
10 changes: 5 additions & 5 deletions specification/containerservice/Fleet.Management/update/run.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,24 +304,24 @@ enum TargetType {

@doc("The definition of a single skip request.")
@added(Versions.v2024_02_02_preview)
model SkipRequest {
model SkipTarget {
@doc("The skip target type.")
type: TargetType;

@doc("""
The skip target.
The skip target's name.
To skip a member/group/stage, use the member/group/stage's name;
Tp skip an after stage wait, use the parent stage's name.
""")
target: string;
name: string;
}

@doc("The properties of a skip operation containing multiple skip requests.")
@added(Versions.v2024_02_02_preview)
model SkipProperties {
@doc("The targets to skip.")
@extension("x-ms-identifiers", ["target"])
targets: SkipRequest[];
@extension("x-ms-identifiers", ["type", "name"])
targets: SkipTarget[];
}

@added(Versions.v2023_03_15_preview)
Expand Down
4 changes: 2 additions & 2 deletions ...Microsoft.ContainerService/fleet/preview/2024-02-02-preview/examples/UpdateRuns_Skip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
"targets": [
{
"type": "Member",
"target": "member-one"
"name": "member-one"
},
{
"type": "AfterStageWait",
"target": "stage1"
"name": "stage1"
}
]
}
Expand Down
13 changes: 7 additions & 6 deletions .../resource-manager/Microsoft.ContainerService/fleet/preview/2024-02-02-preview/fleets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2443,33 +2443,34 @@
"type": "array",
"description": "The targets to skip.",
"items": {
"$ref": "#/definitions/SkipRequest"
"$ref": "#/definitions/SkipTarget"
},
"x-ms-identifiers": [
"target"
"type",
"name"
]
}
},
"required": [
"targets"
]
},
"SkipRequest": {
"SkipTarget": {
"type": "object",
"description": "The definition of a single skip request.",
"properties": {
"type": {
"$ref": "#/definitions/TargetType",
"description": "The skip target type."
},
"target": {
"name": {
"type": "string",
"description": "The skip target. \nTo skip a member/group/stage, use the member/group/stage's name;\nTp skip an after stage wait, use the parent stage's name."
"description": "The skip target's name. \nTo skip a member/group/stage, use the member/group/stage's name;\nTp skip an after stage wait, use the parent stage's name."
}
},
"required": [
"type",
"target"
"name"
]
},
"SubnetResourceId": {
Expand Down