Skip to content

[ADF] Swagger Change for Responsys Source #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 1 commit into from
Mar 28, 2018
Merged

[ADF] Swagger Change for Responsys Source #2735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...esource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,6 +1427,18 @@
],
"properties": {
}
},
"ResponsysObjectDataset": {
"x-ms-discriminator-value": "ResponsysObject",
"description": "Responsys dataset.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/Dataset"
}
],
"properties": {
}
}
}
}
57 changes: 57 additions & 0 deletions ...e-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4060,6 +4060,63 @@
"domain",
"accessToken"
]
},
"ResponsysLinkedService": {
"x-ms-discriminator-value": "Responsys",
"description": "Responsys linked service.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/LinkedService"
}
],
"properties": {
"typeProperties": {
"description": "Responsys linked service properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/ResponsysLinkedServiceTypeProperties"
}
},
"required": [
Copy link
Contributor

@dsgouda dsgouda Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the examples if any

Copy link
Contributor Author

@ninishaha ninishaha Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing should be updated in example since we just added a new connector.

"typeProperties"
]
},
"ResponsysLinkedServiceTypeProperties": {
"description": "Responsys linked service properties.",
"properties": {
"endpoint": {
Copy link
Contributor

@dsgouda dsgouda Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please check which of these properties should be marked readonly

Copy link
Contributor Author

@ninishaha ninishaha Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep align with other ODBC connectors. BTW, how can it be marked as read only?

Copy link
Contributor

@dsgouda dsgouda Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example

"description": "The endpoint of the Responsys server.",
"type": "object"
},
"clientId": {
"description": "The client ID associated with the Responsys application. Type: string (or Expression with resultType string).",
"type": "object"
},
"clientSecret": {
"description": "The client secret associated with the Responsys application. Type: string (or Expression with resultType string).",
"$ref": "../datafactory.json#/definitions/SecretBase"
},
"useEncryptedEndpoints": {
"description": "Specifies whether the data source endpoints are encrypted using HTTPS. The default value is true. Type: boolean (or Expression with resultType boolean).",
"type": "object"
},
"useHostVerification": {
"description": "Specifies whether to require the host name in the server's certificate to match the host name of the server when connecting over SSL. The default value is true. Type: boolean (or Expression with resultType boolean).",
"type": "object"
},
"usePeerVerification": {
"description": "Specifies whether to verify the identity of the server when connecting over SSL. The default value is true. Type: boolean (or Expression with resultType boolean).",
"type": "object"
},
"encryptedCredential": {
"description": "The encrypted credential used for authentication. Credentials are encrypted using the integration runtime credential manager. Type: string (or Expression with resultType string).",
"type": "object"
}
},
"required": [
"endpoint",
"clientId"
]
}
}
}
17 changes: 16 additions & 1 deletion ...source-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,7 +1076,22 @@
"description": "A query to retrieve data from source. Type: string (or Expression with resultType string)."
}
}
},
},
"ResponsysSource": {
"description": "A copy activity Responsys source.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/CopySource"
}
],
"properties": {
"query": {
"type": "object",
"description": "A query to retrieve data from source. Type: string (or Expression with resultType string)."
}
}
} ,
"AmazonRedshiftSource": {
"description": "A copy activity source for Amazon Redshift Source.",
"type": "object",
Expand Down