Skip to content

update nginx examples#27220

Merged
qiaozha merged 6 commits into
Azure:mainfrom
kazrael2119:update-nginx-example
Mar 18, 2024
Merged

update nginx examples#27220
qiaozha merged 6 commits into
Azure:mainfrom
kazrael2119:update-nginx-example

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

customer met an issue Azure/azure-sdk-for-js#28126 when using sdk samples which are generated by swagger examples.
It is because the parameter name mismatch. So I create a pr to fix this.

@limingu ,could you help review this pr? thanks

@kazrael2119 kazrael2119 requested review from limingu and qiaozha January 2, 2024 06:54
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 2, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 2, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 11 Errors, 0 Warnings failed [Detail]
Rule Message
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/preview/2021-05-01-preview/swagger.json#L181:22
ExampleUrl: preview/2021-05-01-preview/examples/Certificates_Delete.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/preview/2021-05-01-preview/swagger.json#L454:22
ExampleUrl: preview/2021-05-01-preview/examples/Configurations_Delete.json
READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
Url: NGINX.NGINXPLUS/preview/2021-05-01-preview/swagger.json#L1221:17
ExampleUrl: preview/2021-05-01-preview/examples/Deployments_Create.json#L7:13
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/preview/2021-05-01-preview/swagger.json#L669:22
ExampleUrl: preview/2021-05-01-preview/examples/Deployments_Delete.json
READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
Url: NGINX.NGINXPLUS/preview/2024-01-01-preview/swagger.json#L1396:17
ExampleUrl: preview/2024-01-01-preview/examples/Deployments_Create.json#L7:13
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L181:22
ExampleUrl: stable/2022-08-01/examples/Certificates_Delete.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L454:22
ExampleUrl: stable/2022-08-01/examples/Configurations_Delete.json
READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L1221:17
ExampleUrl: stable/2022-08-01/examples/Deployments_Create.json#L7:13
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L669:22
ExampleUrl: stable/2022-08-01/examples/Deployments_Delete.json
READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
Url: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L1248:17
ExampleUrl: stable/2023-04-01/examples/Deployments_Create.json#L7:13
READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
Url: NGINX.NGINXPLUS/stable/2023-09-01/swagger.json#L1321:17
ExampleUrl: stable/2023-09-01/examples/Deployments_Create.json#L7:13
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 2, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking


️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/nginx/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Nginx [View full logs]  [Preview SDK Changes]
    warn	Skip artifact folder because it doesn't exist: artifacts/packages
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.5.0` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-nginx [View full logs]  [Preview SDK Changes]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] t
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0k      0 --:--:-- --:--:-- --:--:--  818k
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.0` to update!
    cmderr	[init.sh] npm notice
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-nginx [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/nginx/armnginx [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-nginx [View full logs]  [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.0` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • ️✔️nginx [View full logs
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from e38fdb76a0770dbf8ae44142c77066560ec3a52c. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.nginx.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jan 2, 2024

@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 5, 2024
@openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added the no-recent-activity There has been no recent activity on this issue. label Jan 22, 2024
@kazrael2119 kazrael2119 removed the no-recent-activity There has been no recent activity on this issue. label Jan 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 12, 2024
@kazrael2119 kazrael2119 reopened this Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 27, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
@openapi-pipeline-app openapi-pipeline-app Bot added the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants