Skip to content

Conversation

@gadongji
Copy link
Contributor

@gadongji gadongji commented Mar 20, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@gadongji gadongji requested a review from a user March 20, 2018 03:10
@gadongji
Copy link
Contributor Author

For MySQL and PostgreSQL, we are introducing a new property, connectionString, to replace all the previous properties.
For Teradata and DB2, the property, schema, is removed since it is already deprecated according to our docs.

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#18

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2475

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2293

@sarangan12
Copy link
Contributor

Please fix the errors reported in https://travis-ci.org/Azure/azure-rest-api-specs/jobs/355678382 for approval

@gadongji
Copy link
Contributor Author

Hi @sarangan12, the errors are not caused by my changes I think. Or could you please point out how I need to fix it.
BTW, please hold on a while before merge this PR into master, thanks.

@lmazuel
Copy link
Member

lmazuel commented Mar 22, 2018

@AutorestCI rebuild azure-sdk-for-python

@sarangan12
Copy link
Contributor

@gadongji The changes look ok to me. Do you want this merged or should I still hold?

@hvermis
Copy link
Contributor

hvermis commented Mar 23, 2018

@sarangan12 please go ahead and merge.

@gadongji
Copy link
Contributor Author

@sarangan12 @hvermis please still hold, we want to wait until UX ready. Will let you know when we want to merge :) Thanks.

@sarangan12
Copy link
Contributor

STill waiting

@gadongji
Copy link
Contributor Author

Yes, please still hold. Thanks.

@sarangan12
Copy link
Contributor

@gadongji Any Updates

@gadongji
Copy link
Contributor Author

@sarangan12 please still hold :)

@gadongji
Copy link
Contributor Author

@sarangan12 please help complete this PR now. Our UX is ready now and thanks for your patient. :)

@gadongji
Copy link
Contributor Author

Hi @sarangan12, could you please help merge this PR now? Thanks very much.

@gadongji
Copy link
Contributor Author

Hi @sarangan12, please merge this PR at your first convenience :)

@AutorestCI
Copy link

AutorestCI commented Apr 18, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants