-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Allow subscription parameter for the checkNameAvailability API #2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We already have the checkNameAvailability API but that does not take the subscription id as a parameter. We support the API both with subscription as an optional parameter. Added an operation which takes subscription id as a parameter.
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpxty8r0h_/rest/specification/cdn/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpxty8r0h_/sdk', '--use=@microsoft.azure/autorest.python@2.1.40', '--version=preview'] AutoRest code generation utility [version: 2.0.4259; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4259/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4259)
Loading AutoRest extension '@microsoft.azure/autorest.python' (2.1.40->2.1.40)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR: Referenced file 'file:///tmp/tmpxty8r0h_/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/examples/CheckNameAvailabilityWithSubscription.json' not found
- file:///tmp/tmpxty8r0h_/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/cdn.json:1762:12 ($.paths["/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/checkNameAvailability"].post["x-ms-examples"].CheckNameAvailabilityWithSubscription["$ref"])
FATAL: swagger-document/loader - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpeb0bn34g/rest/specification/cdn/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpeb0bn34g/sdk', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.95', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
Including configuration file 'file:///tmp/tmpeb0bn34g/rest/specification/cdn/resource-manager/readme.go.md'
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-10"} .
Including configuration file 'file:///tmp/tmpeb0bn34g/rest/specification/cdn/resource-manager/readme.go.md'
ERROR: Referenced file 'file:///tmp/tmpeb0bn34g/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/examples/CheckNameAvailabilityWithSubscription.json' not found
- file:///tmp/tmpeb0bn34g/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/cdn.json:1762:12 ($.paths["/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/checkNameAvailability"].post["x-ms-examples"].CheckNameAvailabilityWithSubscription["$ref"])
FATAL: swagger-document/loader - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failure during batch task - {"tag":"package-2017-10"} -- false. |
Automation for azure-libraries-for-javaEncountered a Subprocess error: (azure-libraries-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmp2xzp5rv6/rest/specification/cdn/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp2xzp5rv6/sdk', '--fluent', '--java', '--multiapi', '--verbose'] AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
Including configuration file 'file:///tmp/tmp2xzp5rv6/rest/specification/cdn/resource-manager/readme.java.md'
Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
ERROR: Referenced file 'file:///tmp/tmp2xzp5rv6/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/examples/CheckNameAvailabilityWithSubscription.json' not found
- file:///tmp/tmp2xzp5rv6/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/cdn.json:1762:12 ($.paths["/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/checkNameAvailability"].post["x-ms-examples"].CheckNameAvailabilityWithSubscription["$ref"])
FATAL: swagger-document/loader - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. |
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmp4e3ts2jz/rest/specification/cdn/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp4e3ts2jz/sdk', '--nodejs'] AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.28)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR: Referenced file 'file:///tmp/tmp4e3ts2jz/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/examples/CheckNameAvailabilityWithSubscription.json' not found
- file:///tmp/tmp4e3ts2jz/rest/specification/cdn/resource-manager/Microsoft.Cdn/stable/2017-10-12/cdn.json:1762:12 ($.paths["/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/checkNameAvailability"].post["x-ms-examples"].CheckNameAvailabilityWithSubscription["$ref"])
FATAL: swagger-document/loader - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. |
* add a new datawarehouse resource type in the swagger * add datawarehouse resource type to operation API
We already have the checkNameAvailability API but that does not take the subscription id as a parameter. We support the API both with subscription as an optional parameter. Added an operation which takes subscription id as a parameter.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger