[OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name #26960

deyaaeldeen · 2023-12-06T06:37:15Z

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

a private preview
a public preview
GA release

Change Scope

^{This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.}

Design Document:
Previous API Spec Doc:
Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Helpful Links

Azure DevTools Wiki

Checks stuck in `queued` state?

If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

openapi-pipeline-app · 2023-12-06T06:37:18Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-12-06T06:37:19Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-12-06T06:37:20Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from e1e3062ef4cc179d6c3975c33d5ba49fa8a5d3ea. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.AI.OpenAI [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️❌ azure-sdk-for-java failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from e1e3062ef4cc179d6c3975c33d5ba49fa8a5d3ea. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py]  WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 10.2.4
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[generate.py] npm notice Run `npm install -g [email protected]` to update!
cmderr	[generate.py] npm notice
cmderr	[generate.py] java.lang.RuntimeException: java.lang.NullPointerException
cmderr	[generate.py] 	at com.azure.autorest.TypeSpecPlugin.customizeGeneratedCode(TypeSpecPlugin.java:154)
cmderr	[generate.py] 	at com.azure.typespec.Main.handleDPG(Main.java:137)
cmderr	[generate.py] 	at com.azure.typespec.Main.main(Main.java:93)
cmderr	[generate.py] Caused by: java.lang.NullPointerException
cmderr	[generate.py] 	at com.azure.autorest.TypeSpecPlugin.customizeGeneratedCode(TypeSpecPlugin.java:148)
cmderr	[generate.py] 	... 2 more
cmderr	[generate.py] Emitter "@azure-tools/typespec-java" crashed! This is a bug.
cmderr	[generate.py] Please file an issue at https://github.com/Azure/autorest.java/issues
cmderr	[generate.py] Error: JAR ended with code '1'.
cmderr	[generate.py]     at ChildProcess.<anonymous> (file:///mnt/vss/_work/1/s/azure-sdk-for-java/sdk/openai/azure-ai-openai/TempTypeSpecFiles/OpenAI.Inference/node_modules/@azure-tools/typespec-java/dist/src/emitter.js:106:37)
cmderr	[generate.py]     at ChildProcess.emit (node:events:513:28)
cmderr	[generate.py]     at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
cmderr	[generate.py] --------------------------------------------------
cmderr	[generate.py] Library Version                0.11.2
cmderr	[generate.py] TypeSpec Compiler Version      0.50.0
cmderr	[generate.py] --------------------------------------------------
cmderr	[generate.py] �[31;1mWrite-Error: �[31;1mFailed to generate sdk project at /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/openai/azure-ai-openai�[0m
error	Fatal error: The "path" argument must be of type string. Received undefined
The "path" argument must be of type string. Received undefined
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:387:5)
    at validateString (node:internal/validators:162:11)
    at Object.basename (node:path:1309:5)
    at Object.exports.getPackageData (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/types/PackageData.js:38:82)
    at /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:210:194
    at Array.map (<anonymous>)
    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:210:164)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:98:13)
    at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:211:13)
    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

️🔄 azure-sdk-for-js inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-12-06T06:37:21Z

Generated ApiView

Language	Package Name	ApiView Link
TypeSpec	OpenAI.Inference	https://apiview.dev/Assemblies/Review/33bce38a792d4c69ba4f11a73f01b352

[OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name

b3f9554

deyaaeldeen requested review from lmazuel and trrwilson December 6, 2023 06:37

deyaaeldeen requested a review from yangyuan as a code owner December 6, 2023 06:37

openapi-assignment-bot bot assigned lmazuel Dec 6, 2023

deyaaeldeen mentioned this pull request Dec 6, 2023

Azure OpenAI: TypeSpec updates for 2023-12-01-preview #26737

Merged

AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Dec 6, 2023

azure-sdk mentioned this pull request Dec 6, 2023

[AutoPR Azure.AI.OpenAI] [OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name azure-sdk/azure-sdk-for-net#6445

Closed

jpalvarezl approved these changes Dec 6, 2023

View reviewed changes

lmazuel merged commit be00d0b into main Dec 7, 2023

lmazuel deleted the openai/correct-function-name-type branch December 7, 2023 17:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name #26960

[OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name #26960

Uh oh!

deyaaeldeen commented Dec 6, 2023

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name #26960

[OpenAI] Update type for ChatCompletionsNamedFunctionToolSelection.name #26960

Uh oh!

Conversation

deyaaeldeen commented Dec 6, 2023

Data Plane API - Pull Request

API Info: The Basics

Change Scope

Viewing API changes

Suppressing failures

❔Got questions? Need additional info?? We are here to help!

Tooling

Guidelines & Specifications

Helpful Links

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Dec 6, 2023 •

edited

Loading