Release release sentinel securityinsights microsoft.security insights 2023 11 01#26873
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| types.json | 2.0(88bc770) | 2.0(main) |
️❌Breaking Change(Cross-Version): 3 Errors, 43 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| ContentPackages.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| ContentProductPackages.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| ContentProductTemplates.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| ContentTemplates.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| SourceControls.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| ContentCommonTypes.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| AlertRules.json | 2023-11-01(88bc770) | 2023-02-01(main) |
| AlertRules.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
| Watchlists.json | 2023-11-01(88bc770) | 2023-02-01(main) |
| Watchlists.json | 2023-11-01(88bc770) | 2023-10-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
1025 - RequiredStatusChange |
The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1072:7 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1072:7 |
1025 - RequiredStatusChange |
The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L469:7 Old: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L469:7 |
1049 - RemovedXmsEnum |
The new version is missing a 'x-ms-enum' found in the old version. New: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L482:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L482:9 |
The following breaking changes are detected by comparison with the latest preview version:
Only 27 items are listed, please refer to log for more details.
️❌LintDiff: 23 Errors, 65 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2023-11 | package-2023-11(88bc770) | package-2023-11(release-release-sentinel-securityinsights-Microsoft.SecurityInsights-2023-11-01) |
[must fix]The following errors/warnings are introduced by current PR:
Only 27 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L158 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L255 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L274 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L282 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L151 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L151 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L170 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L170 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L178 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L185 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L210 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductPackages.json#L217 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductTemplates.json#L156 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductTemplates.json#L179 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductTemplates.json#L192 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentProductTemplates.json#L209 |
RPC-Policy-V1-03 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentTemplates.json#L118 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentTemplates.json#L254 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentTemplates.json#L277 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentTemplates.json#L285 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentTemplates.json#L311 |
RPC-Policy-V1-03 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentTemplates.json#L328 |
RPC-Policy-V1-03 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/SourceControls.json#L185 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L37 |
RPC-Get-V1-11 | |
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L51 |
||
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L54 |
||
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/ContentPackages.json#L57 |
The following errors/warnings exist before current PR submission:
Only 27 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L149 |
PutRequestResponseSchemeArm |
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Actions_CreateOrUpdate' Request Model: 'parameters[6].schema' Response Model: 'responses[200].schema' Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L329 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L340 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1165 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1208 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1444 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1610 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1637 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L186 |
RepeatedPathInfo |
The 'watchlistAlias' already appears in the path, please don't repeat it in the request body. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L199 |
RequestBodyMustExistForPutPatch |
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L383 |
RepeatedPathInfo |
The 'watchlistItemId' already appears in the path, please don't repeat it in the request body. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L399 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L578 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L578 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L596 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L596 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L643 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.SecurityInsights/stable/2023-11-01/Watchlists.json#L647 |
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L37 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L51 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L54 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L57 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L102 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L105 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L108 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L151 |
|
| Use the latest version v5 of types.json. Location: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L154 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
Please address or respond to feedback from the ARM API reviewer. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| }, | ||
| "packagedContent": { | ||
| "type": "object", | ||
| "description": "the json to deploy" |
There was a problem hiding this comment.
please elaborate more in description like it's an ARM template and can be used to deploy resources so that the users know how to use this property
There was a problem hiding this comment.
updated. Please check. Thank you.
|
@ms-zhenhua |
294fd1d
into
Azure:release-release-sentinel-securityinsights-Microsoft.SecurityInsights-2023-11-01
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.