Skip to content

Fix type of detected to be boolean as returned by service#26863

Merged
lmazuel merged 1 commit into
mainfrom
rbeckers/fixTypeInDecemberPreview
Nov 28, 2023
Merged

Fix type of detected to be boolean as returned by service#26863
lmazuel merged 1 commit into
mainfrom
rbeckers/fixTypeInDecemberPreview

Conversation

@bexxx
Copy link
Copy Markdown
Member

@bexxx bexxx commented Nov 28, 2023

Data Plane API - Pull Request

Swagger does not reflect actual service behavior (no svc change).

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Checks stuck in `queued` state? If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

@bexxx bexxx requested a review from yangyuan as a code owner November 28, 2023 16:35
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 28, 2023

Next Steps to Merge

⌛ Please wait, next steps to merge this PR are being evaluated by automation. ⌛

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 28, 2023

Swagger Validation Report

️⌛BreakingChange pending [Detail]
️⌛Breaking Change(Cross-Version) pending [Detail]
️⌛CredScan pending [Detail]
️⌛LintDiff pending [Detail]
️⌛Avocado pending [Detail]
️⌛SwaggerAPIView pending [Detail]
️⌛TypeSpecAPIView pending [Detail]
️⌛ModelValidation pending [Detail]
️⌛SemanticValidation pending [Detail]
️⌛PoliCheck pending [Detail]
️⌛SpellCheck pending [Detail]
️⌛Lint(RPaaS) pending [Detail]
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 28, 2023

Swagger Generation Artifacts

️⌛ApiDocPreview pending [Detail]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 28, 2023
@lmazuel lmazuel merged commit 9c7722c into main Nov 28, 2023
@lmazuel lmazuel deleted the rbeckers/fixTypeInDecemberPreview branch November 28, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants