PR workflow diagram update#26816
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
updated asset url and removed obsolete notes.
|
@raych1 if they don't get an answer or have questions where should they direct them? Also is there a query or some way to see them on the list of things to be reviewed? Also for my information is the plan to centrally triage and review these? |
Use new link of diagram. Removed unused sdk breaking change reviewers pinned link.
@weshaggard , the pinned post for SDK reviewers in Teams channel is still active and available for users to seek further assistance. The purpose of this PR is to fix the issue in the diagram. As for a direct GitHub query link for the candidate PRs requiring SDK breaking change review, I haven't figured out yet. The challenge is that the query needs to cover various scenarios, such as PRs that do or don't require API breaking change review, and those that do or don't require ARM review. At this time, I don't foresee a plan to centralize the SDK breaking change review process in near future. However, we will explore when we roll out the new review workflow. |
The action suggested for PR authors is not correct in the diagram.
The SDK breaking change will be evaluated within two business days after the completion of the first two steps. SDK breaking change review is conducted proactively and doesn’t need PR authors to post a message in the support channel. Reviewers will reserve some time every workday to review the candidate PRs.
@konrad-jamrozik @weshaggard please review and merge this PR, thanks.