Skip to content

PR workflow diagram update#26816

Merged
raych1 merged 5 commits into
mainfrom
raych1-patch-1
Nov 28, 2023
Merged

PR workflow diagram update#26816
raych1 merged 5 commits into
mainfrom
raych1-patch-1

Conversation

@raych1
Copy link
Copy Markdown
Member

@raych1 raych1 commented Nov 22, 2023

The action suggested for PR authors is not correct in the diagram.

The SDK breaking change will be evaluated within two business days after the completion of the first two steps. SDK breaking change review is conducted proactively and doesn’t need PR authors to post a message in the support channel. Reviewers will reserve some time every workday to review the candidate PRs.

@konrad-jamrozik @weshaggard please review and merge this PR, thanks.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

updated asset url and removed obsolete notes.
@weshaggard
Copy link
Copy Markdown
Member

@raych1 if they don't get an answer or have questions where should they direct them? Also is there a query or some way to see them on the list of things to be reviewed?

Also for my information is the plan to centrally triage and review these?

Copy link
Copy Markdown

@konrad-jamrozik konrad-jamrozik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and left few comments.

Comment thread .github/PULL_REQUEST_TEMPLATE/control_plane_template.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE/control_plane_template.md
Comment thread .github/PULL_REQUEST_TEMPLATE/control_plane_template.md
Use new link of diagram.
Removed unused sdk breaking change reviewers pinned link.
@raych1
Copy link
Copy Markdown
Member Author

raych1 commented Nov 23, 2023

@raych1 if they don't get an answer or have questions where should they direct them? Also is there a query or some way to see them on the list of things to be reviewed?

Also for my information is the plan to centrally triage and review these?

@weshaggard , the pinned post for SDK reviewers in Teams channel is still active and available for users to seek further assistance. The purpose of this PR is to fix the issue in the diagram.

As for a direct GitHub query link for the candidate PRs requiring SDK breaking change review, I haven't figured out yet. The challenge is that the query needs to cover various scenarios, such as PRs that do or don't require API breaking change review, and those that do or don't require ARM review.

At this time, I don't foresee a plan to centralize the SDK breaking change review process in near future. However, we will explore when we roll out the new review workflow.

@raych1 raych1 merged commit 738ab25 into main Nov 28, 2023
@raych1 raych1 deleted the raych1-patch-1 branch November 28, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants