Azure Active Directory change to Microsoft Entra ID by apoorvasingh130 · Pull Request #26815 · Azure/azure-rest-api-specs

apoorvasingh130 · 2023-11-22T10:43:31Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-11-22T10:43:36Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-11-22T10:43:37Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
logz.json	2020-10-01-preview(d5ef81b)	2020-10-01-preview(main)
logz.json	2022-01-01-preview(d5ef81b)	2022-01-01-preview(main)
logz.json	2020-10-01(d5ef81b)	2020-10-01(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2022-01-01-preview	package-2022-01-01-preview(d5ef81b)	package-2022-01-01-preview(main)
package-2020-10-01-preview	package-2020-10-01-preview(d5ef81b)	package-2020-10-01-preview(main)
package-2020-10-01	package-2020-10-01(d5ef81b)	package-2020-10-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L29
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L35
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L96
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L203
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L332
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L363
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L420
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L468
`❌` ResourceNameRestriction	The resource name parameter 'ruleSetName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L468
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L469
`❌` DeleteResponseCodes	An async DELETE operation must set ''x-ms-long-running-operation' : true'. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L577
`❌` LroExtension	Operations with a 202 response must specify `x-ms-long-running-operation: true`. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L577
`❌` XMSLongRunningOperationProperty	If an operation's (PUT/POST/PATCH/DELETE) responses have `Location` or `Azure-AsyncOperation` headers then it MUST have the property `x-ms-long-running-operation` set to `true` Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L613
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L636
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L684
`❌` ResourceNameRestriction	The resource name parameter 'configurationName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L684
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L804
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L852
`❌` ResourceNameRestriction	The resource name parameter 'subAccountName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L852
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L965
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1049
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1081
`❌` ResourceNameRestriction	The resource name parameter 'subAccountName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1081
`❌` ResourceNameRestriction	The resource name parameter 'monitorName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1132
`❌` ResourceNameRestriction	The resource name parameter 'subAccountName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1132
`❌` ResourceNameRestriction	The resource name parameter 'ruleSetName' should be defined with a 'pattern' restriction. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1132
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1133
`❌` DeleteResponseCodes	An async DELETE operation must set ''x-ms-long-running-operation' : true'. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1247
`❌` LroExtension	Operations with a 202 response must specify `x-ms-long-running-operation: true`. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1247
`❌` XMSLongRunningOperationProperty	If an operation's (PUT/POST/PATCH/DELETE) responses have `Location` or `Azure-AsyncOperation` headers then it MUST have the property `x-ms-long-running-operation` set to `true` Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1286

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-22T10:43:38Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from eda8ebd409edc0931e70a83c8cf67938a200f77c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.4` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-logz [View full logs] [Preview SDK Changes]
- azure_mgmt_logz-1.0.0b1-py3-none-any.whl
- azure-mgmt-logz-1.0.0b1.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from eda8ebd409edc0931e70a83c8cf67938a200f77c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-logz [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from eda8ebd409edc0931e70a83c8cf67938a200f77c. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/logz/armlogz [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from eda8ebd409edc0931e70a83c8cf67938a200f77c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-logz [View full logs] [Preview SDK Changes]

azure-arm-logz-1.0.0.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from eda8ebd409edc0931e70a83c8cf67938a200f77c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.4` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️logz [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from eda8ebd409edc0931e70a83c8cf67938a200f77c. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.logz.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.logz.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-22T10:43:39Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/logz/armlogz	https://apiview.dev/Assemblies/Review/61fd78369b73415b8b454b3bce018c67
Java	azure-resourcemanager-logz	There is no API change compared with the previous version
JavaScript	@azure/arm-logz	https://apiview.dev/Assemblies/Review/cda572ee6a7c408689bf9351ddbecab2
Swagger	Microsoft.Logz	https://apiview.dev/Assemblies/Review/7777f393415c4ddeabf200da7a34414b

apoorvasingh130 · 2023-11-24T06:08:35Z

/pr RequestMerge

Azure Active Directory change to Microsoft Entra ID

2b40ec9

openapi-assignment-bot Bot assigned rkmanda Nov 22, 2023

This was referenced Nov 22, 2023

[AutoPR logz] Azure Active Directory change to Microsoft Entra ID azure-sdk/azure-resource-manager-schemas#3717

Draft

[AutoPR sdk/resourcemanager/logz/armlogz] Azure Active Directory change to Microsoft Entra ID azure-sdk/azure-sdk-for-go#8277

Closed

vipray-ms added Liftr Marketplace-Liftr RPs IDCDevDiv labels Nov 22, 2023

AzureRestAPISpecReview added ARMReview resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 22, 2023

azure-sdk mentioned this pull request Nov 22, 2023

[AutoPR track2_azure-mgmt-logz] Azure Active Directory change to Microsoft Entra ID azure-sdk/azure-sdk-for-python#5441

Closed

Merge branch 'Azure:main' into main

a53617c

This was referenced Nov 22, 2023

[AutoPR @azure/arm-logz] Azure Active Directory change to Microsoft Entra ID azure-sdk/azure-sdk-for-js#7782

Closed

[AutoPR azure-resourcemanager-logz] Azure Active Directory change to Microsoft Entra ID azure-sdk/azure-sdk-for-java#8625

Closed

Add missing location headers

d5ef81b

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Nov 22, 2023

mukundnigam added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 24, 2023

openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 24, 2023

microsoft-github-policy-service Bot added the MergeRequested label Nov 24, 2023

rkmanda approved these changes Nov 28, 2023

View reviewed changes

rkmanda merged commit 1631971 into Azure:main Nov 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Active Directory change to Microsoft Entra ID#26815

Azure Active Directory change to Microsoft Entra ID#26815
rkmanda merged 3 commits into
Azure:mainfrom
apoorvasingh130:main

apoorvasingh130 commented Nov 22, 2023

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

Uh oh!

apoorvasingh130 commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

apoorvasingh130 commented Nov 22, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

apoorvasingh130 commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 22, 2023 •

edited

Loading