Skip to content

Reusing the OSSku definition and renaming definitions to avoid overlap in SDK - HybridAKS 2023-11-15-preview #26741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raosuhas merged 6 commits into from
Nov 22, 2023
Merged

Reusing the OSSku definition and renaming definitions to avoid overlap in SDK - HybridAKS 2023-11-15-preview #26741

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e10a8c6
Reusing the OSSku definition
HariPrasadV Nov 16, 2023
96c2fd8
Adding readonly flag and default value
HariPrasadV Nov 16, 2023
662f5cd
Renaming properties structure to avoid overlap
HariPrasadV Nov 17, 2023
7bbb4b2
Fixing the readonly
HariPrasadV Nov 17, 2023
994ab4a
fixing the casing
HariPrasadV Nov 17, 2023
2982f56
Fixing Model Validation
HariPrasadV Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions ...rosoft.HybridContainerService/preview/2023-11-15-preview/provisionedClusterInstances.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,15 +1775,15 @@
"type": "array",
"description": "List of supported Kubernetes versions",
"items": {
"$ref": "#/definitions/KubernetesVersionProfileProperties"
"$ref": "#/definitions/KubernetesVersionProperties"
},
"x-ms-identifiers": []
}
}
}
}
},
"KubernetesVersionProfileProperties": {
"KubernetesVersionProperties": {
"type": "object",
"description": "Kubernetes version profile for given major.minor release",
"properties": {
Expand Down Expand Up @@ -1866,19 +1866,7 @@
}
},
"osSku": {
"type": "string",
"description": "The particular KubernetesVersion's Image's OS SKU (CBLMariner, Windows, Windows2022)",
"readOnly": true,
"enum": [
"CBLMariner",
"Windows2019",
"Windows2022"
],
"default": "CBLMariner",
"x-ms-enum": {
"modelAsString": true,
"name": "osSku"
}
"$ref": "#/definitions/OSSKU"
},
"ready": {
"type": "boolean",
Expand Down Expand Up @@ -1948,15 +1936,15 @@
"type": "array",
"description": "Array of HybridAKS Support VM Skus",
"items": {
"$ref": "#/definitions/VmSkuProfileProperties"
"$ref": "#/definitions/VmSkuProperties"
},
"x-ms-identifiers": []
}
}
}
}
},
"VmSkuProfileProperties": {
"VmSkuProperties": {
"type": "object",
"description": "The profile for supported VM skus",
"readOnly": true,
Expand Down