Skip to content

Adding new version 2023-11-01-preview for updating monitor Properties#26659

Merged
rkmanda merged 7 commits into
Azure:mainfrom
RheaHooda23:main
Nov 28, 2023
Merged

Adding new version 2023-11-01-preview for updating monitor Properties#26659
rkmanda merged 7 commits into
Azure:mainfrom
RheaHooda23:main

Conversation

@RheaHooda23
Copy link
Copy Markdown
Contributor

@RheaHooda23 RheaHooda23 commented Nov 10, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 10, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@RheaHooda23 RheaHooda23 requested a review from poshett November 10, 2023 03:54
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 10, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 29 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
elastic.json 2023-11-01-preview(c51d896) 2023-06-01(main)
elastic.json 2023-11-01-preview(c51d896) 2023-10-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L78:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L78:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L120:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L120:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L169:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L169:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L214:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L214:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L260:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L260:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L324:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L324:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L375:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L375:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L424:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L424:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L472:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L472:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L517:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L517:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L663:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L570:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L714:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L621:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L768:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L675:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L814:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L721:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L866:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L773:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L914:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L821:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L959:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L866:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1009:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L916:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1057:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L964:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1108:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1015:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1153:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1060:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1198:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1105:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1259:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1166:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1326:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1233:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1378:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1285:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1426:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1333:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1478:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1385:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1530:9
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1437:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L632:5
Old: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2478:5
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-11-01-preview package-2023-11-01-preview(c51d896) default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L48
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L204
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L298
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L337
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L366
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L393
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L402
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L414
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L462
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L507
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L560
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L605
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L653
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L701
ResourceNameRestriction The resource name parameter 'ruleSetName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L701
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L702
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L805
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L835
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L844
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L856
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L904
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L949
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L999
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1044
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1080
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1086
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1098
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1143
ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1188
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Elastic/preview/2023-11-01-preview/elastic.json#L1189
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 10, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/elastic/armelastic - Approved - 0.10.0
+	Function `*timeRFC3339.Parse` has been removed
+	Function `*timeRFC3339.UnmarshalText` has been removed
+	Function `timeRFC3339.MarshalText` has been removed

️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 3dfe308f18a4f9498f4c30538de781147669284d. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-elastic [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation OrganizationsOperations.get_elastic_to_azure_subscription_mapping
    info	[Changelog]   - Added operation group BillingInfoOperations
    info	[Changelog]   - Added operation group ConnectedPartnerResourcesOperations
    info	[Changelog]   - Model DeploymentInfoResponse has a new parameter elasticsearch_end_point
    info	[Changelog]   - Model MarketplaceSaaSInfo has a new parameter billed_azure_subscription_id
    info	[Changelog]   - Model MarketplaceSaaSInfo has a new parameter marketplace_status
    info	[Changelog]   - Model MarketplaceSaaSInfo has a new parameter subscribed
    info	[Changelog]   - Model MonitorProperties has a new parameter plan_details
    info	[Changelog]   - Model MonitorProperties has a new parameter saa_s_azure_subscription_status
    info	[Changelog]   - Model MonitorProperties has a new parameter source_campaign_id
    info	[Changelog]   - Model MonitorProperties has a new parameter source_campaign_name
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 3dfe308f18a4f9498f4c30538de781147669284d. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-elastic [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 3dfe308f18a4f9498f4c30538de781147669284d. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/elastic/armelastic [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `timeRFC3339.MarshalText` has been removed
    info	[Changelog] - Function `*timeRFC3339.Parse` has been removed
    info	[Changelog] - Function `*timeRFC3339.UnmarshalText` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New function `NewBillingInfoClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BillingInfoClient, error)`
    info	[Changelog] - New function `*BillingInfoClient.Get(context.Context, string, string, *BillingInfoClientGetOptions) (BillingInfoClientGetResponse, error)`
    info	[Changelog] - New function `*ClientFactory.NewBillingInfoClient() *BillingInfoClient`
    info	[Changelog] - New function `*ClientFactory.NewConnectedPartnerResourcesClient() *ConnectedPartnerResourcesClient`
    info	[Changelog] - New function `NewConnectedPartnerResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ConnectedPartnerResourcesClient, error)`
    info	[Changelog] - New function `*ConnectedPartnerResourcesClient.NewListPager(string, string, *ConnectedPartnerResourcesClientListOptions) *runtime.Pager[ConnectedPartnerResourcesClientListResponse]`
    info	[Changelog] - New function `*OrganizationsClient.GetElasticToAzureSubscriptionMapping(context.Context, *OrganizationsClientGetElasticToAzureSubscriptionMappingOptions) (OrganizationsClientGetElasticToAzureSubscriptionMappingResponse, error)`
    info	[Changelog] - New function `dateTimeRFC3339.MarshalText() ([]byte, error)`
    info	[Changelog] - New function `*dateTimeRFC3339.Parse(string) error`
    info	[Changelog] - New function `*dateTimeRFC3339.UnmarshalText([]byte) error`
    info	[Changelog] - New struct `BillingInfoResponse`
    info	[Changelog] - New struct `ConnectedPartnerResourceProperties`
    info	[Changelog] - New struct `ConnectedPartnerResourcesListFormat`
    info	[Changelog] - New struct `ConnectedPartnerResourcesListResponse`
    info	[Changelog] - New struct `OrganizationToAzureSubscriptionMappingResponse`
    info	[Changelog] - New struct `OrganizationToAzureSubscriptionMappingResponseProperties`
    info	[Changelog] - New struct `PartnerBillingEntity`
    info	[Changelog] - New struct `PlanDetails`
    info	[Changelog] - New field `ElasticsearchEndPoint` in struct `DeploymentInfoResponse`
    info	[Changelog] - New field `BilledAzureSubscriptionID`, `MarketplaceStatus`, `Subscribed` in struct `MarketplaceSaaSInfo`
    info	[Changelog] - New field `PlanDetails`, `SaaSAzureSubscriptionStatus`, `SourceCampaignID`, `SourceCampaignName` in struct `MonitorProperties`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 29 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 3dfe308f18a4f9498f4c30538de781147669284d. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️elastic [View full logs]  [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 3dfe308f18a4f9498f4c30538de781147669284d. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.elastic.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.elastic.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 10, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/elastic/armelastic https://apiview.dev/Assemblies/Review/2734085f6f84407798d376aae4c02ff6
Java azure-resourcemanager-elastic https://apiview.dev/Assemblies/Review/7d8c9231c89745539e1379bb9ac51773
Swagger Microsoft.Elastic https://apiview.dev/Assemblies/Review/71b2a68631f34467a26ec95f4fe63884

@openapi-workflow-bot
Copy link
Copy Markdown

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot
Copy link
Copy Markdown

Hi @RheaHooda23! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@vipray-ms vipray-ms added Liftr Marketplace-Liftr RPs IDCDevDiv labels Nov 10, 2023
@vipray-ms
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@RheaHooda23
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@RheaHooda23 RheaHooda23 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 13, 2023
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 13, 2023
@mnasnh1009 mnasnh1009 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 14, 2023
@raych1 raych1 added Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go and removed Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go labels Nov 20, 2023
@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 21, 2023
@raych1 raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 22, 2023
@vipray-ms
Copy link
Copy Markdown
Member

/pr RequestMerge

@rkmanda rkmanda merged commit 565e209 into Azure:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-MissingBaseCommit IDCDevDiv Liftr Marketplace-Liftr RPs new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants