Skip to content

[Hub Generated] Review request for Microsoft.Migrate/Microsoft.Migrate to add version stable/2023-03-15 #26562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zizw123 merged 2 commits into from
Nov 8, 2023
Merged

[Hub Generated] Review request for Microsoft.Migrate/Microsoft.Migrate to add version stable/2023-03-15 #26562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93c51cb
Hotfix. fix property name by adding new assessed disk model.
kuchatur-ms Nov 3, 2023
30ce569
example fix
kuchatur-ms Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...entProjects/stable/2023-03-15/examples/AssessedMachinesOperations_Get_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"suitabilityDetail": "NumberOfReadOperationsPerSecondMissing",
"recommendedDiskSize": "StandardSSD_E10",
"recommendedDiskType": "StandardSSD",
"recommendedDiskSizeGigabytes": 17,
"gigabytesForRecommendedDiskSize": 17,
"recommendDiskThroughputInMbps": 13,
"recommendedDiskIops": 7,
"monthlyStorageCost": 5,
Expand Down
2 changes: 1 addition & 1 deletion ...table/2023-03-15/examples/AssessedMachinesOperations_ListByAssessment_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"suitabilityDetail": "NumberOfReadOperationsPerSecondMissing",
"recommendedDiskSize": "StandardSSD_E10",
"recommendedDiskType": "StandardSSD",
"recommendedDiskSizeGigabytes": 17,
"gigabytesForRecommendedDiskSize": 17,
"recommendDiskThroughputInMbps": 13,
"recommendedDiskIops": 7,
"monthlyStorageCost": 5,
Expand Down
82 changes: 80 additions & 2 deletions ...rate/resource-manager/Microsoft.Migrate/AssessmentProjects/stable/2023-03-15/migrate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5153,7 +5153,85 @@
},
"AssessedDisk": {
"type": "object",
"description": "Assessed Disk.",
"properties": {
"suitability": {
"$ref": "#/definitions/CloudSuitability",
"description": "Gets the suitability."
},
"suitabilityExplanation": {
"$ref": "#/definitions/AzureDiskSuitabilityExplanation",
"description": "Gets the suitability explanation."
},
"suitabilityDetail": {
"$ref": "#/definitions/AzureDiskSuitabilityDetail",
"description": "Gets the suitability detail."
},
"recommendedDiskSize": {
"$ref": "#/definitions/AzureDiskSize",
"description": "Gets the recommended disk size."
},
"recommendedDiskType": {
"$ref": "#/definitions/AzureDiskType",
"description": "Gets the recommended disk type."
},
"gigabytesForRecommendedDiskSize": {
"type": "integer",
"format": "int32",
"description": "Gets the recommended disk size."
},
"recommendDiskThroughputInMbps": {
Comment thread
kuchatur-ms marked this conversation as resolved.
"type": "number",
"format": "float",
"description": "Gets the recommended disk throughput."
},
"recommendedDiskIops": {
"type": "number",
"format": "float",
"description": "Gets the recommended disk iops."
},
"monthlyStorageCost": {
"type": "number",
"format": "float",
"description": "Gets the monthly storage cost."
},
"name": {
"type": "string",
"description": "Gets the name."
},
"displayName": {
"type": "string",
"description": "Gets the machine display name."
},
"gigabytesProvisioned": {
"type": "number",
"format": "float",
"description": "Gets the gigabytes provisioned."
},
"megabytesPerSecondOfRead": {
"type": "number",
"format": "float",
"description": "Gets the megabytes per second of read."
},
"megabytesPerSecondOfWrite": {
"type": "number",
"format": "float",
"description": "Gets the megabytes per second of write."
},
"numberOfReadOperationsPerSecond": {
"type": "number",
"format": "float",
"description": "Gets the number of read operations per second."
},
"numberOfWriteOperationsPerSecond": {
"type": "number",
"format": "float",
"description": "Gets the number of write operations per second."
}
}
},
"AssessedDiskData": {
"type": "object",
"description": "Assessed Disk data. Used in Assessed SQL machine DTO.",
"properties": {
"suitability": {
"$ref": "#/definitions/CloudSuitability",
Expand Down Expand Up @@ -6188,7 +6266,7 @@
"type": "object",
"description": "Gets the list of data disks that were assessed as part of this assessment.",
"additionalProperties": {
"$ref": "#/definitions/AssessedDisk"
"$ref": "#/definitions/AssessedDiskData"
},
"readOnly": true
},
Expand Down