Adding new preview version "2023-11-01-preview" with new APIs#26528
Merged
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| NewRelic.json | 2023-11-01-preview(03e7dcc) | 2022-07-01(main) |
| NewRelic.json | 2023-11-01-preview(03e7dcc) | 2023-10-01-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 37 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2023-11-01-preview | package-2023-11-01-preview(03e7dcc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
Cadl
|
Hi @vipray-ms! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Nov 2, 2023
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
This reverts commit 90a9177.
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
Member
Author
openapi-pipeline-app
Bot
added
CI-BreakingChange-JavaScript
CI-BreakingChange-Go
labels
The URI path suggests that this operation gets the monitored subscriptions on a monitor by configuration. If that's the case, could you please update the summary? Refers to: specification/newrelic/resource-manager/NewRelic.Observability/preview/2023-11-01-preview/NewRelic.json:1377 in 085c053. [](commit_id = 085c053, deletion_comment = False) |
From the path parameter description, it appears that the configuration of the monitored subscription is a singleton resource. Only default is supported. Would recommend adopting the best practices for modelling singleton resource. There are two ways:
{ Refers to: specification/newrelic/resource-manager/NewRelic.Observability/preview/2023-11-01-preview/NewRelic.json:1372 in 085c053. [](commit_id = 085c053, deletion_comment = False) |
openapi-workflow-bot
Bot
removed
the
WaitForARMFeedback
Member
Author
Current summary is correct, the resource via which this API would get call, this API will return the list of subscriptions monitored by that resource. |
Member
Author
Done, Please check. Thanks. |
vipray-ms
added
WaitForARMFeedback
mnasnh1009
added
the
ARMSignedOff
openapi-workflow-bot
Bot
removed
the
WaitForARMFeedback
kazrael2119
reviewed
Nov 17, 2023
raych1
added
the
Approved-SdkBreakingChange-Go
Member
Author
|
/pr RequestMerge |
sjanamma
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.