[API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParameters by zdelacerda-microsoft · Pull Request #26487 · Azure/azure-rest-api-specs

zdelacerda-microsoft · 2023-10-31T06:55:39Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-10-31T06:55:43Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-workflow-bot · 2023-10-31T06:55:43Z

Hi @zdelacerda-microsoft, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

You can refer to Service API Toolset Introduction for details.

Please contact service focal contacts or Service API Toolset Support Channel if need further help.

openapi-pipeline-app · 2023-10-31T06:55:43Z

Swagger Validation Report

️❌BreakingChange: 14 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
imagebuilder.json	2023-07-01(bd256d9)	2023-07-01(main)

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1724:9 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1725:9
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'source' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'customize' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'optimize' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'validate' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'errorHandling' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'provisioningState' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'provisioningError' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'lastRunStatus' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'buildTimeoutInMinutes' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'vmProfile' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'stagingResourceGroup' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'exactStagingResourceGroup' renamed or removed? New: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1727:11 Old: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1496:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 1 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-07	package-2023-07(bd256d9)	package-2023-07(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1724

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L217
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L332
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L359
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L381
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L408
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L740
`❌` XmsParameterLocation	The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1980
`❌` XmsParameterLocation	The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L2030
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L44
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L44
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L44
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L44
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L83
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L83
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L83
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L83
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L125
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L125
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L125
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L125
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L187
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L187
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L187
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L187
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L246
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L246
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L246
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L246
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L286
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L286

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-31T06:55:44Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from fa44665. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-imagebuilder [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ImageTemplate has a new parameter error_handling
info	[Changelog]   - Model ImageTemplateUpdateParameters has a new parameter properties

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from fa44665. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-imagebuilder [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fa44665. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/virtualmachineimagebuilder/armvirtualmachineimagebuilder [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `OnBuildError` with values `OnBuildErrorAbort`, `OnBuildErrorCleanup`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New struct `ImageTemplatePropertiesErrorHandling`
info	[Changelog] - New struct `ImageTemplateUpdateParametersProperties`
info	[Changelog] - New field `ErrorHandling` in struct `ImageTemplateProperties`
info	[Changelog] - New field `Properties` in struct `ImageTemplateUpdateParameters`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 15 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fa44665. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-imagebuilder [View full logs] [Release SDK Changes]

azure-arm-imagebuilder-3.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ErrorAdditionalInfo
info	[Changelog]   - Added Interface ErrorDetail
info	[Changelog]   - Added Interface ErrorResponse
info	[Changelog]   - Added Interface ImageTemplatePropertiesErrorHandling
info	[Changelog]   - Added Interface ImageTemplateUpdateParametersProperties
info	[Changelog]   - Added Type Alias OnBuildError
info	[Changelog]   - Added Type Alias TriggersDeleteResponse
info	[Changelog]   - Added Type Alias VirtualMachineImageTemplatesDeleteResponse
info	[Changelog]   - Interface ImageTemplate has a new optional parameter errorHandling
info	[Changelog]   - Interface ImageTemplateUpdateParameters has a new optional parameter properties
info	[Changelog]   - Added Enum KnownOnBuildError

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from fa44665. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.2` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️imagebuilder [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from fa44665. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.imagebuilder.DefaultTag [View full logs]

Az.ImageBuilder.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.imagebuilder.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-31T06:55:45Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/virtualmachineimagebuilder/armvirtualmachineimagebuilder	https://apiview.dev/Assemblies/Review/a4266ca88ca14a4f80451d34125ce458
Java	azure-resourcemanager-imagebuilder	https://apiview.dev/Assemblies/Review/8384d518459044b9b44bbc2d62eb39f7
JavaScript	@azure/arm-imagebuilder	https://apiview.dev/Assemblies/Review/dfd27ae5dba14b65b48cc5428baae7ec

openapi-workflow-bot · 2023-10-31T07:01:36Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

zdelacerda-microsoft · 2023-10-31T07:07:08Z

@rkmanda can you mark this PR with breaking change approval? We've already gotten the sign-off from this PR:
#26309

rkmanda

mikeharder · 2023-10-31T22:54:57Z

/azp run TypeSpec Validation

azure-pipelines · 2023-10-31T22:55:06Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-pipeline-app · 2023-10-31T22:56:41Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…eters (#26487) * fixing distribute in ImageTemplateUpdateParameters * prettier * removing x-ms-identifiers from ImageTemplate

fixing distribute in ImageTemplateUpdateParameters

ba33d68

openapi-assignment-bot Bot assigned rkmanda Oct 31, 2023

openapi-workflow-bot Bot added the ShiftLeftViolation label Oct 31, 2023

openapi-workflow-bot Bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 31, 2023

zdelacerda-microsoft removed the ShiftLeftViolation label Oct 31, 2023

azure-sdk mentioned this pull request Oct 31, 2023

[AutoPR track2_azure-mgmt-imagebuilder] [API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParameters azure-sdk/azure-sdk-for-python#5199

Closed

prettier

989f3f5

azure-sdk mentioned this pull request Oct 31, 2023

[AutoPR azure-resourcemanager-imagebuilder] [API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParameters azure-sdk/azure-sdk-for-java#8178

Closed

ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 31, 2023

openapi-workflow-bot Bot removed the ARMChangesRequested label Oct 31, 2023

removing x-ms-identifiers from ImageTemplate

bd256d9

AzureRestAPISpecReview added ARMChangesRequested and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Oct 31, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 31, 2023

zdelacerda-microsoft removed the ARMChangesRequested label Oct 31, 2023

openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2023

rkmanda approved these changes Oct 31, 2023

View reviewed changes

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 31, 2023

openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2023

rkmanda approved these changes Oct 31, 2023

View reviewed changes

rkmanda enabled auto-merge (squash) October 31, 2023 22:52

rkmanda removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 31, 2023

rkmanda merged commit fa44665 into main Oct 31, 2023

rkmanda deleted the zdelacerda-microsoft-imagebuilder-update-2023-07-01 branch October 31, 2023 22:56

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

[API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParam…

44aaada

…eters (#26487) * fixing distribute in ImageTemplateUpdateParameters * prettier * removing x-ms-identifiers from ImageTemplate

zdelacerda-microsoft mentioned this pull request Nov 29, 2023

Azure Image Builder New API Version Request - 2023-07-01 Azure/azure-cli#27946

Closed

1 task

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

[API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParam…

6002d35

…eters (#26487) * fixing distribute in ImageTemplateUpdateParameters * prettier * removing x-ms-identifiers from ImageTemplate

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParameters#26487

[API 2023-07-01 Update] Fixing distribute in ImageTemplateUpdateParameters#26487
rkmanda merged 3 commits into
mainfrom
zdelacerda-microsoft-imagebuilder-update-2023-07-01

zdelacerda-microsoft commented Oct 31, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Oct 31, 2023

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Oct 31, 2023

Uh oh!

zdelacerda-microsoft commented Oct 31, 2023 •

edited

Loading

Uh oh!

rkmanda left a comment

Uh oh!

mikeharder commented Oct 31, 2023

Uh oh!

azure-pipelines Bot commented Oct 31, 2023

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

zdelacerda-microsoft commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-workflow-bot Bot commented Oct 31, 2023

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot Bot commented Oct 31, 2023

Uh oh!

zdelacerda-microsoft commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rkmanda left a comment

Choose a reason for hiding this comment

Uh oh!

mikeharder commented Oct 31, 2023

Uh oh!

azure-pipelines Bot commented Oct 31, 2023

Uh oh!

openapi-pipeline-app Bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zdelacerda-microsoft commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Oct 31, 2023 •

edited

Loading

zdelacerda-microsoft commented Oct 31, 2023 •

edited

Loading