Skip to content

Conversation

@gdhillon24
Copy link
Contributor

@gdhillon24 gdhillon24 commented Oct 27, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 27, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 27, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
applicationGateway.json 2023-06-01(3be66e4) 2023-05-01(main)
️❌LintDiff: 6 Errors, 0 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-06 package-2023-06(3be66e4) package-2023-06(release-network-Microsoft.Network-official-2023-06-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManager.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined')
Location: azure-rest-api-specs/blob/3be66e46c97d64de4a2b1a8deb47ea964f4caef5/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerConnection.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined')
Location: azure-rest-api-specs/blob/3be66e46c97d64de4a2b1a8deb47ea964f4caef5/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerConnectivityConfiguration.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined')
Location: azure-rest-api-specs/blob/3be66e46c97d64de4a2b1a8deb47ea964f4caef5/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerGroup.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined')
Location: azure-rest-api-specs/blob/3be66e46c97d64de4a2b1a8deb47ea964f4caef5/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerScopeConnection.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined')
Location: azure-rest-api-specs/blob/3be66e46c97d64de4a2b1a8deb47ea964f4caef5/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerSecurityAdminConfiguration.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined')
Location: azure-rest-api-specs/blob/3be66e46c97d64de4a2b1a8deb47ea964f4caef5/#L1


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateLinkServices/{serviceName}/privateLinkResources is missing.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L36
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L37
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L38
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L72
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L84
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L194
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L234
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L351
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L352
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L389
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L395
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L405
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L406
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L443
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L449
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L459
ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L471
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L507
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L513
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L523
ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L535
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L580
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L586
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L596
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L649
ResourceNameRestriction The resource name parameter 'connectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L649
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L650
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L691
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L703
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2023-06-01/applicationGateway.json#L712
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 27, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking




️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 030b0a9d36f0ed04d5d8786063a1e32dafa1afdb. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Network [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 030b0a9d36f0ed04d5d8786063a1e32dafa1afdb. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.1
    cmderr	[automation_generate.sh]  Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
    cmderr	[automation_generate.sh] npm  Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-network [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 030b0a9d36f0ed04d5d8786063a1e32dafa1afdb. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 030b0a9d36f0ed04d5d8786063a1e32dafa1afdb. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ActionTypeJSChallenge` added to enum type `ActionType`
    info	[Changelog] - New value `BastionHostSKUNameDeveloper` added to enum type `BastionHostSKUName`
    info	[Changelog] - New value `FirewallPolicyIDPSSignatureDirectionFour`, `FirewallPolicyIDPSSignatureDirectionThree` added to enum type `FirewallPolicyIDPSSignatureDirection`
    info	[Changelog] - New value `VirtualNetworkGatewaySKUNameErGwScale` added to enum type `VirtualNetworkGatewaySKUName`
    info	[Changelog] - New value `VirtualNetworkGatewaySKUTierErGwScale` added to enum type `VirtualNetworkGatewaySKUTier`
    info	[Changelog] - New value `WebApplicationFirewallActionJSChallenge` added to enum type `WebApplicationFirewallAction`
    info	[Changelog] - New enum type `FirewallPolicyIntrusionDetectionProfileType` with values `FirewallPolicyIntrusionDetectionProfileTypeAdvanced`, `FirewallPolicyIntrusionDetectionProfileTypeBasic`, `FirewallPolicyIntrusionDetectionProfileTypeExtended`, `FirewallPolicyIntrusionDetectionProfileTypeStandard`
    info	[Changelog] - New function `*ManagementClient.BeginDeleteBastionShareableLinkByToken(context.Context, string, string, BastionShareableLinkTokenListRequest, *ManagementClientBeginDeleteBastionShareableLinkByTokenOptions) (*runtime.Poller[ManagementClientDeleteBastionShareableLinkByTokenResponse], error)`
    info	[Changelog] - New struct `BastionShareableLinkTokenListRequest`
    info	[Changelog] - New struct `InternetIngressPublicIPsProperties`
    info	[Changelog] - New field `HostNames` in struct `ApplicationGatewayListenerPropertiesFormat`
    info	[Changelog] - New field `Profile` in struct `FirewallPolicyIntrusionDetection`
    info	[Changelog] - New field `InternetIngressPublicIPs` in struct `VirtualAppliancePropertiesFormat`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 20 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 030b0a9d36f0ed04d5d8786063a1e32dafa1afdb. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface BastionShareableLinkTokenListRequest
    info	[Changelog]   - Added Interface DdosCustomPoliciesDeleteHeaders
    info	[Changelog]   - Added Interface DeleteBastionShareableLinkByTokenOptionalParams
    info	[Changelog]   - Added Interface InternetIngressPublicIpsProperties
    info	[Changelog]   - Added Type Alias FirewallPolicyIntrusionDetectionProfileType
    info	[Changelog]   - Interface ApplicationGatewayListener has a new optional parameter hostNames
    info	[Changelog]   - Interface FirewallPolicyIntrusionDetection has a new optional parameter profile
    info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter internetIngressPublicIps
    info	[Changelog]   - Added Enum KnownFirewallPolicyIntrusionDetectionProfileType
    info	[Changelog]   - Enum KnownActionType has a new value JSChallenge
    info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Developer
    info	[Changelog]   - Enum KnownVirtualNetworkGatewaySkuName has a new value ErGwScale
    info	[Changelog]   - Enum KnownVirtualNetworkGatewaySkuTier has a new value ErGwScale
    info	[Changelog]   - Enum KnownWebApplicationFirewallAction has a new value JSChallenge
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 030b0a9d36f0ed04d5d8786063a1e32dafa1afdb. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.network.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.network.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 27, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/b28b1a1642f340988116a45d9fc46c7e
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/b53579cb90bf4a628b83f5edc0e549de
.Net Azure.ResourceManager.Network https://apiview.dev/Assemblies/Review/7e47cc64e1b84392b2f7154245eaa90e
Swagger Microsoft.Network https://apiview.dev/Assemblies/Review/147b4c5449364c5d8b545d1f3bfe0acd

@pcsin pcsin added AzCoreIDC AzCoreIDCSignedOff Indicate sign off by IDC ARM reviewer for further review by ARM team labels Oct 27, 2023
Copy link

@pcsin pcsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 27, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 27, 2023
@rkmanda rkmanda merged commit c9a13dd into Azure:release-network-Microsoft.Network-official-2023-06-01 Oct 27, 2023
zizw123 pushed a commit that referenced this pull request Nov 8, 2023
* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01

* Updates readme

* Updates API version in new specs and examples

* Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599)

* add DeleteBastionShareableLinkByToken endpoint
* fix location link format

* Adding Developer Sku (#25887)

* Firewall Policy - IDPS profiles (#25666)

* add profile to put example

* fixed RuleCollectionGroupWithHttpHeadersToInsert example

* add profile to Policy model

* description change

* indentation

* ListIdpsSignatures description change

* direction description+enum fix

* fix FirewallPolicyIDPSSignatureSeverity description

* hostnames for l4 listeners (#25982)

* added ergwscale support (#25969)

* Fixed examples for gateway load balancer (#26058)

* Add support for JSChallenge action in Application Gateway Web application Firewall (#26149)

* Add support for JSChallenge action

Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules

* Update WafPolicyGet.json

* Update WafPolicyCreateOrUpdate.json

* DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248)

* fixes

* making changes in new api version

---------

Co-authored-by: Manas Chakka <[email protected]>

* [NVA] Internet Ingress Parameters (#26262)

* [NVA] Internet Ingress Parameters

* LintDiff Fix

* Minor Fix

* Added description for each of the enums for ApplicationGatewayProtocol (#26437)

* Added description for each of the enums for ApplicationGatewayProtocol

* Spacing for prettier checks

* Remove routingConfigNfv (#25962)

* remove routingConfigNfv

* remove api from older versions

* remove PUT nvaconnection from older versions

* apply prettier check

* add suppression for modelValidation

* remove suppression due to approval

* Fix lint errors & add supressions (#26494)

* fix lint error

* add supression for ResourceNameRestriction & LroErrorContent

* fix example accordingly

---------

Co-authored-by: htippanaboya <[email protected]>
Co-authored-by: Sijie Lin <[email protected]>
Co-authored-by: anvrao1 <[email protected]>
Co-authored-by: NiviShenker <[email protected]>
Co-authored-by: gdhillon24 <[email protected]>
Co-authored-by: aneeshakella-microsoft <[email protected]>
Co-authored-by: irrogozh <[email protected]>
Co-authored-by: ssevugan21 <[email protected]>
Co-authored-by: Manas Chakka <[email protected]>
Co-authored-by: Manas Chakka <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: rutuja-s <[email protected]>
zman-ms pushed a commit that referenced this pull request Jan 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01

* Updates readme

* Updates API version in new specs and examples

* Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599)

* add DeleteBastionShareableLinkByToken endpoint
* fix location link format

* Adding Developer Sku (#25887)

* Firewall Policy - IDPS profiles (#25666)

* add profile to put example

* fixed RuleCollectionGroupWithHttpHeadersToInsert example

* add profile to Policy model

* description change

* indentation

* ListIdpsSignatures description change

* direction description+enum fix

* fix FirewallPolicyIDPSSignatureSeverity description

* hostnames for l4 listeners (#25982)

* added ergwscale support (#25969)

* Fixed examples for gateway load balancer (#26058)

* Add support for JSChallenge action in Application Gateway Web application Firewall (#26149)

* Add support for JSChallenge action

Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules

* Update WafPolicyGet.json

* Update WafPolicyCreateOrUpdate.json

* DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248)

* fixes

* making changes in new api version

---------

Co-authored-by: Manas Chakka <[email protected]>

* [NVA] Internet Ingress Parameters (#26262)

* [NVA] Internet Ingress Parameters

* LintDiff Fix

* Minor Fix

* Added description for each of the enums for ApplicationGatewayProtocol (#26437)

* Added description for each of the enums for ApplicationGatewayProtocol

* Spacing for prettier checks

* Remove routingConfigNfv (#25962)

* remove routingConfigNfv

* remove api from older versions

* remove PUT nvaconnection from older versions

* apply prettier check

* add suppression for modelValidation

* remove suppression due to approval

* Fix lint errors & add supressions (#26494)

* fix lint error

* add supression for ResourceNameRestriction & LroErrorContent

* fix example accordingly

---------

Co-authored-by: htippanaboya <[email protected]>
Co-authored-by: Sijie Lin <[email protected]>
Co-authored-by: anvrao1 <[email protected]>
Co-authored-by: NiviShenker <[email protected]>
Co-authored-by: gdhillon24 <[email protected]>
Co-authored-by: aneeshakella-microsoft <[email protected]>
Co-authored-by: irrogozh <[email protected]>
Co-authored-by: ssevugan21 <[email protected]>
Co-authored-by: Manas Chakka <[email protected]>
Co-authored-by: Manas Chakka <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: rutuja-s <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review AzCoreIDC AzCoreIDCSignedOff Indicate sign off by IDC ARM reviewer for further review by ARM team resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants