Skip to content

Add RecoveryPointState to DataProtection#26426

Merged
asmitt merged 2 commits into
Azure:asmitt-dataprotection-Microsoft.DataProtection-2023-11-01from
nickpacificomsft:nickpacifico-dataprotection-Microsoft.DataProtection-2023-11-01-RecoveryPointState
Oct 30, 2023
Merged

Add RecoveryPointState to DataProtection#26426
asmitt merged 2 commits into
Azure:asmitt-dataprotection-Microsoft.DataProtection-2023-11-01from
nickpacificomsft:nickpacifico-dataprotection-Microsoft.DataProtection-2023-11-01-RecoveryPointState

Conversation

@nickpacificomsft
Copy link
Copy Markdown
Contributor

@nickpacificomsft nickpacificomsft commented Oct 26, 2023

Add RecoveryPointState swagger changes

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Oct 26, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Oct 26, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 7 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
dataprotection.json 2023-11-01(e541243) 2023-05-01(main)
dataprotection.json 2023-11-01(e541243) 2023-06-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{resourceId}/providers/Microsoft.DataProtection/backupInstances' removed or restructured?
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L1892:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CmkKeyVaultProperties' removed or renamed?
New: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L4100:3
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L4144:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CmkKekIdentity' removed or renamed?
New: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L4100:3
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L4144:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'encryptionSettings' removed or renamed?
New: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L4100:3
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L4144:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceId' removed or renamed?
New: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L7997:3
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L8082:3
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'encryptionSettings' renamed or removed?
New: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L7442:7
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L7541:7
⚠️ 1042 - ChangedParameterOrder The order of parameter 'parameters' was changed.
New: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1833:9
Old: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L1842:9
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-11 package-2023-11(e541243) package-2023-11(asmitt-dataprotection-Microsoft.DataProtection-2023-11-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L42
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L64
ParametersOrder The parameters:operationId,location should be kept in the same order as they present in the path.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L64
GetOperation200 The get operation should only return 200.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L94
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L184
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L307
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L328
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L426
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L440
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L467
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L476
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L526
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L532
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L544
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L545
GetOperation200 The get operation should only return 200.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L580
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L740
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L761
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L788
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L809
ResourceNameRestriction The resource name parameter 'backupPolicyName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L809
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L860
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L969
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L996
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1017
ResourceNameRestriction The resource name parameter 'backupInstanceName' should be defined with a 'pattern' restriction.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1017
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1064
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1128
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1139
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataProtection/stable/2023-11-01/dataprotection.json#L1193
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Oct 26, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️SDK Breaking Change Tracking warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Oct 26, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/dataprotection/armdataprotection https://apiview.dev/Assemblies/Review/04015b89d8db455c941a4f8475917b00
Java azure-resourcemanager-dataprotection https://apiview.dev/Assemblies/Review/7693f17906c641fca6095f6a187d4ace
JavaScript @azure/arm-dataprotection https://apiview.dev/Assemblies/Review/b55ed4fc0cdd4f1aa995a25b43d57909
Swagger Microsoft.DataProtection https://apiview.dev/Assemblies/Review/416049b849fc4edd93609638f2fb88c2

@nickpacificomsft nickpacificomsft marked this pull request as ready for review October 27, 2023 00:56
@asmitt asmitt merged commit 2329daf into Azure:asmitt-dataprotection-Microsoft.DataProtection-2023-11-01 Oct 30, 2023
asmitt pushed a commit that referenced this pull request Oct 31, 2023
* Add RecoveryPointState to DataProtection

* Prettier fixes
asmitt added a commit that referenced this pull request Nov 10, 2023
* Adds base for updating Microsoft.DataProtection from version preview/2023-04-01-preview to version 2023-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* changes for AKS vault tier restore

* address typos

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* copied changes for CRR from api-version 2023-04-01-preview

* added replicated regions to vault and filters to fetch CRR jobs

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-08-01

* Updates readme

* Updates API version in new specs and examples

* removed extension routing changes

* changes for vault tier

* completed with warnings job changes

* Add RecoveryPointState to DataProtection (#26426)

* Add RecoveryPointState to DataProtection

* Prettier fixes

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* copied changes for CRR from api-version 2023-04-01-preview

* added replicated regions to vault and filters to fetch CRR jobs

* removed extension routing changes

* completed with warnings job changes

* Add RecoveryPointState to DataProtection (#26426)

* Add RecoveryPointState to DataProtection

* Prettier fixes

---------

Co-authored-by: Shashank Singh <shashank1306s@gmail.com>
Co-authored-by: asmitt <62243673+asmitt@users.noreply.github.com>
Co-authored-by: Ashish Mittal <asmitt@microsoft.com>
Co-authored-by: nickpacificomsft <144935783+nickpacificomsft@users.noreply.github.com>
kushalmehrotra713 pushed a commit that referenced this pull request Nov 28, 2023
…rsion stable/2023-11-01 (#26491)

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* copied changes for CRR from api-version 2023-04-01-preview

* added replicated regions to vault and filters to fetch CRR jobs

* removed extension routing changes

* completed with warnings job changes

* Add RecoveryPointState to DataProtection

* Asmitt dataprotection microsoft.data protection 2023 11 01 (#26663)

* Adds base for updating Microsoft.DataProtection from version preview/2023-04-01-preview to version 2023-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* changes for AKS vault tier restore

* address typos

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* copied changes for CRR from api-version 2023-04-01-preview

* added replicated regions to vault and filters to fetch CRR jobs

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-08-01

* Updates readme

* Updates API version in new specs and examples

* removed extension routing changes

* changes for vault tier

* completed with warnings job changes

* Add RecoveryPointState to DataProtection (#26426)

* Add RecoveryPointState to DataProtection

* Prettier fixes

* Adds base for updating Microsoft.DataProtection from version stable/2023-05-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* copied changes for CRR from api-version 2023-04-01-preview

* added replicated regions to vault and filters to fetch CRR jobs

* removed extension routing changes

* completed with warnings job changes

* Add RecoveryPointState to DataProtection (#26426)

* Add RecoveryPointState to DataProtection

* Prettier fixes

---------

Co-authored-by: Shashank Singh <shashank1306s@gmail.com>
Co-authored-by: asmitt <62243673+asmitt@users.noreply.github.com>
Co-authored-by: Ashish Mittal <asmitt@microsoft.com>
Co-authored-by: nickpacificomsft <144935783+nickpacificomsft@users.noreply.github.com>

* resolved lint issues

* added missing operation and schema description

* spelling fix

* lint error suppressions

* resolved warnings

* fixed operationId

---------

Co-authored-by: soumyapattnaik <33341338+soumyapattnaik@users.noreply.github.com>
Co-authored-by: Shashank Singh <shashank1306s@gmail.com>
Co-authored-by: nickpacificomsft <144935783+nickpacificomsft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-BreakingChange-Go CI-BreakingChange-JavaScript customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants