adding readme.nodejs.md for automated node sdk generation#2637
adding readme.nodejs.md for automated node sdk generation#2637schaabs wants to merge 1 commit intoAzure:keyvault_previewfrom
Conversation
Automation for azure-libraries-for-javaA PR has been created for you: |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
lmazuel
left a comment
There was a problem hiding this comment.
Syntax is perfect, I can't judge the NodeJS content.
| nodejs: | ||
| azure-arm: true | ||
| license-header: MICROSOFT_MIT_NO_VERSION | ||
| payload-flattening-threshold: 2 |
There was a problem hiding this comment.
I do not use this setting while generating the node sdk. Here is the output when I generate this locally from the node sdk gulp file.js
>>>>>>>>>>>>>>>>>>>Start: "azure-keyvault" >>>>>>>>>>>>>>>>>>>>>>>>>
Executing command:
------------------------------------------------------------
autorest --output-folder=/Users/amarz/sdk/azure-sdk-for-node/lib/services/keyvault/lib --package-name=azure-keyvault --nodejs --license-header=MICROSOFT_MIT_NO_VERSION --azure-arm https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/keyvault/data-plane/readme.md
------------------------------------------------------------
Output:
AutoRest code generation utility [version: 2.0.4245; node: v8.9.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/private/var/folders/23/8g7f__gs1v39mrr49b8pc8pc0000gn/T/.autorest/@microsoft.azure_autorest-core@2.0.4245/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4245)
Installing AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25)
Installing AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44)
>>>>>>>>>>>>>>>>>>>>>End: "azure-keyvault" >>>>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>Start: "azure-arm-keyvault" >>>>>>>>>>>>>>>>>>>>>>>>>
Executing command:
------------------------------------------------------------
autorest --output-folder=/Users/amarz/sdk/azure-sdk-for-node/lib/services/keyVaultManagement/lib --package-name=azure-arm-keyvault --nodejs --license-header=MICROSOFT_MIT_NO_VERSION --azure-arm https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/keyvault/resource-manager/readme.md
------------------------------------------------------------
Output:
AutoRest code generation utility [version: 2.0.4245; node: v8.9.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/private/var/folders/23/8g7f__gs1v39mrr49b8pc8pc0000gn/T/.autorest/@microsoft.azure_autorest-core@2.0.4245/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4245)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.28)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
>>>>>>>>>>>>>>>>>>>>>End: "azure-arm-keyvault" >>>>>>>>>>>>>>>>>>>>>>>>>
|
Hi @schaabs ! THanks for sending this, Dan and Riki "assigned" are planning on plugging the whole Node SDK into the AUto Generation and will include this part in. @daschult and @RikkiGibson let's sync-up on this tomorrow and see if we should pull this in or wait for your upcoming changes. |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger