[Microsoft.Workloads/monitors] Add a new API version 2023-10-01-preview#26341
Merged
zizw123 merged 14 commits intoAzure:mainfrom Nov 10, 2023
Merged
Conversation
adityaku-ms
requested review from
jsntcy,
msyyc,
qiaozha and
tadelesh
as code owners
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Oct 23, 2023
AzureRestAPISpecReview
added
ARMChangesRequested
ARMReview
BreakingChangeReviewRequired
|
Please address or respond to feedback from the ARM API reviewer. |
This was referenced Oct 23, 2023
AzureRestAPISpecReview
added
the
ReadyForApiTest
mikekistler
added
the
Approved-BreakingChange
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Contributor
Author
|
Added suppression for GuidCheck LintDiff check as it was failing for principalId and tenantId under MSI properties |
zizw123
added
Approved-Suppression
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
zizw123
approved these changes
Nov 10, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Nov 10, 2023
This was referenced Nov 10, 2023
adityaku-ms
deleted the
adityaku-ms/workloads-monitors-new-2023-10-01-preview
branch
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
…ew (#26341) * Adding the base for Microsoft.Workloads/monitors from previous version * Added readme files * Added new version changes * Added commonTypes v2 file and updated Operations_List * Updated readme * Removed Canceled provisioning state from existing resources * Changed extension name in readme files and updated readme for go * Fixed lint errors * Removed 200 status code from delete examples * Added suppression for GuidUsage lint error * Reverting back to v3 for common-types to fix failing SDK checks * Updated readme * Removed length constraints * Updated regex patterns for monitors and providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
This is to add a new API version 2023-10-01-preview for Microsoft.workloads/monitors resource type. This is already present in the private repo.
Couldn't use the Open API hub tool because we're moving to a new folder structure where each RT under the RP will have their own versions.
This is linked to the following PR in the private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/15178
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.