Skip to content

[TypeSpec Validation] Quote argument to "tsp format" #26210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharder merged 1 commit into from
Oct 13, 2023
Merged

[TypeSpec Validation] Quote argument to "tsp format" #26210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/tools/TypeSpecValidation/src/rules/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export class FormatRule implements Rule {
async execute(folder: string): Promise<RuleResult> {
// Format parent folder to include shared files

let [err, stdOutput, errorOutput] = await runCmd(`npx tsp format ../**/*.tsp`, folder);
let [err, stdOutput, errorOutput] = await runCmd(`npx tsp format "../**/*.tsp"`, folder);
// Failing on both err and errorOutput because of known bug in tsp format where it returns 0 on failed formatting
// https://github.com/microsoft/typespec/issues/2323
let success = !err && !errorOutput;
Expand Down