Update azure developer signing typespec project per Review meeting#26197
Closed
Jaxelr wants to merge 6 commits intoAzure:mainfrom
Jaxelr:jaxel/developer-signing-2023-06-15-changes-sdk-review
Closed
Update azure developer signing typespec project per Review meeting#26197Jaxelr wants to merge 6 commits intoAzure:mainfrom Jaxelr:jaxel/developer-signing-2023-06-15-changes-sdk-review
Jaxelr wants to merge 6 commits intoAzure:mainfrom
Jaxelr:jaxel/developer-signing-2023-06-15-changes-sdk-review
Conversation
Renamed Azure.CodeSigning to Azure.Developer.Signing per SDK review Renamed sign operations to replace codesigning for signing Simplified models and prop names per Sdk review feedback Corrected example header for polling operation Corrected examples to use modified structure
Jaxelr
requested review from
DominikMe and
JeffreyRichter
and removed request for
a team
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @Jaxelr! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Oct 12, 2023
…ld to generate sdks
This reverts commit 870d7a4.
JeffreyRichter
added
the
Approved-BreakingChange
Member
Author
|
Closing this PR to open a verison using OpenApi Hub |
Jaxelr
deleted the
jaxel/developer-signing-2023-06-15-changes-sdk-review
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions:
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links