Skip to content

Changing innerError to innererror. Fix ttl examples#26160

Merged
lmazuel merged 2 commits intomainfrom
user/osaghaso/quick_router_fixs
Oct 10, 2023
Merged

Changing innerError to innererror. Fix ttl examples#26160
lmazuel merged 2 commits intomainfrom
user/osaghaso/quick_router_fixs

Conversation

@osaghaso
Copy link
Copy Markdown
Contributor

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

Addressing minor variable name change in the router events add.

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Oct 10, 2023

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Oct 10, 2023

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
AzureCommunicationServices.json 2018-01-01(5b9ed9f) 2018-01-01(main)
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'innerError' renamed or removed?
New: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1816:7
Old: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1816:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ttl' renamed or removed?
New: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1845:7
Old: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1845:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-06-01-preview package-2023-06-01-preview(5b9ed9f) package-2023-06-01-preview(main)

The following errors/warnings exist before current PR submission:

Rule Message
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1688
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1692
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L343
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L467
⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L963
⚠️ PropertyDescription Property should have a description.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L963
⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L992
⚠️ PropertyDescription Property should have a description.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L992
⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1066
⚠️ PropertyDescription Property should have a description.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1066
⚠️ AdditionalPropertiesObject additionalProperties with type object is a common error.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1093
⚠️ PropertyDescription Property should have a description.
Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L1093
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️🔄PR Summary inProgress [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Oct 10, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 3b6ae2e. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.Messaging.EventGrid [View full logs]  [Release SDK Changes]
    info	[Changelog]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Oct 10, 2023

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid https://apiview.dev/Assemblies/Review/8342f3dd91c04749ad7b28c261d46473

@lmazuel lmazuel merged commit 3b6ae2e into main Oct 10, 2023
@lmazuel lmazuel deleted the user/osaghaso/quick_router_fixs branch October 10, 2023 22:55
@openapi-pipeline-app
Copy link
Copy Markdown

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
* Fixing mistake in the Routerevents add on to SDK

* changing ttl to ttlseconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants