Skip to content

Comments

[Synapse]Sync Credential CRUD From DataFactory To Synapse#26128

Merged
lmazuel merged 12 commits intoAzure:mainfrom
Jingshu918:main
Oct 17, 2023
Merged

[Synapse]Sync Credential CRUD From DataFactory To Synapse#26128
lmazuel merged 12 commits intoAzure:mainfrom
Jingshu918:main

Conversation

@Jingshu918
Copy link
Contributor

@Jingshu918 Jingshu918 commented Oct 9, 2023

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Swagger Validation Report

️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
Pipeline.json 2020-12-01(ed11d98) 2020-12-01(main)
credential.json 2020-12-01(ed11d98) 2020-12-01(main)
Rule Message
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L2257:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L2257:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L2292:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L2295:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L2331:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L2337:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L2370:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L2379:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L2409:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L2421:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L4140:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L4155:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L4175:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L4193:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L4210:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L4231:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L4245:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L4269:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: stable/2020-12-01/entityTypes/Pipeline.json#L7709:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L7736:9
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.Synapse/stable/2020-12-01/credential.json#L29:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.Synapse/stable/2020-12-01/credential.json#L65:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.Synapse https://apiview.dev/Assemblies/Review/294e382e126e4896a961bcd0b19ee717

@Jingshu918 Jingshu918 closed this Oct 9, 2023
@Jingshu918 Jingshu918 reopened this Oct 9, 2023
@Jingshu918 Jingshu918 changed the title Sync Credential CRUD From DataFactory To Synapse [Synapse]Sync Credential CRUD From DataFactory To Synapse Oct 9, 2023
@Jingshu918 Jingshu918 closed this Oct 9, 2023
@Jingshu918 Jingshu918 reopened this Oct 9, 2023
@Jingshu918 Jingshu918 closed this Oct 9, 2023
@Jingshu918 Jingshu918 reopened this Oct 9, 2023
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed NewApiVersionRequired labels Oct 9, 2023
@Jingshu918 Jingshu918 closed this Oct 9, 2023
@Jingshu918 Jingshu918 reopened this Oct 9, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

@AzureRestAPISpecReview AzureRestAPISpecReview added NewApiVersionRequired and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Oct 9, 2023
@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 13, 2023
@Jingshu918 Jingshu918 closed this Oct 17, 2023
@Jingshu918 Jingshu918 reopened this Oct 17, 2023
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed NewApiVersionRequired labels Oct 17, 2023
@lmazuel lmazuel merged commit 9bcba68 into Azure:main Oct 17, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
* Sync Credential CRUD From DataFactory To Synapse

* fix

* fix

* fix

* fix

* fix

* fix

* url

* change

* fix

* fix comments

* add
zman-ms pushed a commit that referenced this pull request Jan 10, 2024
* Sync Credential CRUD From DataFactory To Synapse

* fix

* fix

* fix

* fix

* fix

* fix

* url

* change

* fix

* fix comments

* add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants