In Network Fabric , fabricVersion is made read/write from readonly by Mohana-Krishna-Nali · Pull Request #25985 · Azure/azure-rest-api-specs

Mohana-Krishna-Nali · 2023-09-27T11:18:15Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-27T11:18:18Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-27T11:18:19Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
NetworkFabrics.json	2023-06-15(14298bf)	2023-06-15(main)

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.ManagedNetworkFabric/stable/2023-06-15/NetworkFabrics.json#L1514:9 Old: Microsoft.ManagedNetworkFabric/stable/2023-06-15/NetworkFabrics.json#L1514:9
`❌` 1036 - ConstraintChanged	The new version has a different 'minLength' value than the previous one. New: Microsoft.ManagedNetworkFabric/stable/2023-06-15/NetworkFabrics.json#L1514:9 Old: Microsoft.ManagedNetworkFabric/stable/2023-06-15/NetworkFabrics.json#L1514:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.5)	new version	base version
package-2023-06-15	package-2023-06-15(14298bf)	package-2023-06-15(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-27T11:18:20Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 622891e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*NetworkFabricsClient.BeginUpgrade` parameter(s) have been changed from `(context.Context, string, string, UpdateVersion, *NetworkFabricsClientBeginUpgradeOptions)` to `(context.Context, string, string, UpgradeNetworkFabricProperties, *NetworkFabricsClientBeginUpgradeOptions)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ConfigurationStatePendingCommit`, `ConfigurationStateProvisioning` added to enum type `ConfigurationState`
info	[Changelog] - New enum type `NetworkFabricUpgradeAction` with values `NetworkFabricUpgradeActionComplete`, `NetworkFabricUpgradeActionStart`
info	[Changelog] - New struct `UpgradeNetworkFabricProperties`
info	[Changelog] - New field `DefaultAction` in struct `AccessControlListPatchProperties`
info	[Changelog] - New field `DefaultAction` in struct `AccessControlListProperties`
info	[Changelog] - New field `DefaultAction` in struct `RoutePolicyPatchableProperties`
info	[Changelog] - New field `DefaultAction` in struct `RoutePolicyProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 11 additive change(s).

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 622891e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-managednetworkfabric [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 622891e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-managednetworkfabric [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-managednetworkfabric-2.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface UpgradeNetworkFabricProperties
info	[Changelog]   - Added Type Alias NetworkFabricUpgradeAction
info	[Changelog]   - Interface AccessControlList has a new optional parameter defaultAction
info	[Changelog]   - Interface AccessControlListPatch has a new optional parameter defaultAction
info	[Changelog]   - Interface AccessControlListPatchableProperties has a new optional parameter defaultAction
info	[Changelog]   - Interface RoutePolicy has a new optional parameter defaultAction
info	[Changelog]   - Interface RoutePolicyPatch has a new optional parameter defaultAction
info	[Changelog]   - Interface RoutePolicyPatchableProperties has a new optional parameter defaultAction
info	[Changelog]   - Added Enum KnownNetworkFabricUpgradeAction
info	[Changelog]   - Enum KnownConfigurationState has a new value PendingCommit
info	[Changelog]   - Enum KnownConfigurationState has a new value Provisioning
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation NetworkFabrics.beginUpgrade has a new signature
info	[Changelog]   - Operation NetworkFabrics.beginUpgradeAndWait has a new signature

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 622891e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ManagedNetworkFabric [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.ManagedNetworkFabric.1.2.0-alpha.20231012.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.ManagedNetworkFabric/Debug/netstandard2.0/Azure.ResourceManager.ManagedNetworkFabric.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/managednetworkfabric/Azure.ResourceManager.ManagedNetworkFabric/src/Azure.ResourceManager.ManagedNetworkFabric.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 622891e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-managednetworkfabric [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model AccessControlList has a new parameter default_action
info	[Changelog]   - Model AccessControlListPatch has a new parameter default_action
info	[Changelog]   - Model AccessControlListPatchProperties has a new parameter default_action
info	[Changelog]   - Model AccessControlListPatchableProperties has a new parameter default_action
info	[Changelog]   - Model AccessControlListProperties has a new parameter default_action
info	[Changelog]   - Model RoutePolicy has a new parameter default_action
info	[Changelog]   - Model RoutePolicyPatch has a new parameter default_action
info	[Changelog]   - Model RoutePolicyPatchableProperties has a new parameter default_action
info	[Changelog]   - Model RoutePolicyProperties has a new parameter default_action

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-27T11:18:21Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric	https://apiview.dev/Assemblies/Review/13a8471034a34359abd63fb88026a59b
Java	azure-resourcemanager-managednetworkfabric	https://apiview.dev/Assemblies/Review/7bbe166bfa554517874accbdeeedbd97
.Net	Azure.ResourceManager.ManagedNetworkFabric	https://apiview.dev/Assemblies/Review/e991929902114aaba33669a8a31afde7
JavaScript	@azure/arm-managednetworkfabric	https://apiview.dev/Assemblies/Review/1f23a158e83a40f2879ac2ac298f348b

openapi-workflow-bot · 2023-09-27T11:24:32Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

rsmalipatil · 2023-10-11T09:09:03Z

@rkmanda Could you please approve and merge changes

rsmalipatil · 2023-10-12T05:50:56Z

/pr RequestMerge

openapi-pipeline-app · 2023-10-12T08:07:43Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…25985)

In Network Fabric , fabricVersion is made read/write from readonly

14298bf

openapi-assignment-bot bot assigned rkmanda Sep 27, 2023

Mohana-Krishna-Nali requested review from rsmalipatil, sylar217 and umamaheshmsft September 27, 2023 12:14

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 28, 2023

rsmalipatil approved these changes Sep 29, 2023

View reviewed changes

Mohana-Krishna-Nali removed the ARMChangesRequested label Oct 3, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 3, 2023

sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 6, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 6, 2023

sylar217 approved these changes Oct 11, 2023

View reviewed changes

github-actions bot added the MergeRequested label Oct 12, 2023

ms-zhenhua merged commit 622891e into main Oct 12, 2023

ms-zhenhua deleted the dev/v-mnali/Making-Fabric-Version-Optional branch October 12, 2023 08:07

azure-sdk mentioned this pull request Oct 12, 2023

[ReleasePR sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric] In Network Fabric , fabricVersion is made read/write from readonly Azure/azure-sdk-for-go#21640

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 12, 2023

azure-sdk mentioned this pull request Oct 12, 2023

[ReleasePR @azure/arm-managednetworkfabric] In Network Fabric , fabricVersion is made read/write from readonly Azure/azure-sdk-for-js#26288

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Oct 12, 2023

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

In Network Fabric , fabricVersion is made read/write from readonly (#…

a31144c

…25985)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In Network Fabric , fabricVersion is made read/write from readonly#25985

In Network Fabric , fabricVersion is made read/write from readonly#25985
ms-zhenhua merged 1 commit intomainfrom
dev/v-mnali/Making-Fabric-Version-Optional

Mohana-Krishna-Nali commented Sep 27, 2023

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Sep 27, 2023

Uh oh!

rsmalipatil commented Oct 11, 2023

Uh oh!

rsmalipatil commented Oct 12, 2023

Uh oh!

openapi-pipeline-app bot commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

Mohana-Krishna-Nali commented Sep 27, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot bot commented Sep 27, 2023

Uh oh!

rsmalipatil commented Oct 11, 2023

Uh oh!

rsmalipatil commented Oct 12, 2023

Uh oh!

openapi-pipeline-app bot commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 27, 2023 •

edited

Loading