release 2023-04-01 swagger to public repo #25959
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| swagger.json | 2023-04-01(155f9ab) | 2022-08-01(main) |
| swagger.json | 2023-04-01(155f9ab) | 2021-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'tags' renamed or removed? New: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L861:7 Old: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L861:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'tags' renamed or removed? New: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L957:7 Old: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L956:7 |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.5) | new version | base version |
|---|---|---|
| default | default(155f9ab) | default(main) |
️❌Avocado: 17 Errors, 0 Warnings failed [Detail]
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
This is publishing a previously used but not published api version 2023-04-01. As discussed in today's breaking change review office hour, that's the reason we got some breaking change tags on the 2023-09-01 PR. This is required to be done. I'll ping the breaking change reviewers about this PR if there are any breaking change identified. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi @zaowang-ms! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
|
Base commit is not missing. The diff can be viewed here: 155f9ab |
|
The identified breaking change is already approved here https://github.com/Azure/azure-rest-api-specs-pr/pull/12762 . |
|
The initial 2023-04-01 PR approved in azure-rest-api-specs-pr : https://github.com/Azure/azure-rest-api-specs-pr/pull/11959 |
|
Hi @rkmanda , it would be muchly appreciated if anyone from your side can review this sooner. This 2023-04-01 is an already in-use version for a few months and should be all good from all aspects. |
|
/pr RequestMerge |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
* initial commit for adding 2023-04-01 * adding 2023-04-01
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.