Skip to content

Address ARM reviewer comment for community gallery #25803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sandido merged 2 commits into from
Oct 11, 2023
Merged

Address ARM reviewer comment for community gallery #25803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2ebd3
update
kangsun-ctrl Sep 14, 2023
e7a28e2
update
kangsun-ctrl Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...pute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/communityGallery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@
"$ref": "#/definitions/CommunityGalleryIdentifier"
}
},
"description": "Base information about the community gallery resource in pir."
"description": "Base information about the community gallery resource in azure compute gallery."
},
"CommunityGalleryArtifactTags": {
"type": "object",
Expand Down Expand Up @@ -344,6 +344,10 @@
"description": "The link for the privacy statement of this community gallery from the gallery publisher."
}
},
"required": [
"publisherContact",
"publicNames"
],
"description": "The metadata of community gallery."
},
"CommunityGallery": {
Expand Down
2 changes: 1 addition & 1 deletion ...stable/2022-08-03/examples/communityGalleryExamples/CommunityGalleryImageVersion_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"location": "myLocation",
"name": "myGalleryImageVersionName",
"type": "Microsoft.Compute/Locations/CommunityGalleryImageVersion",
"type": "Microsoft.Compute/locations/communityGalleryImageVersion",
"identifier": {
"uniqueId": "/CommunityGalleries/publicGalleryName/Images/myGalleryImageName/Versions/myGalleryImageVersionName"
}
Expand Down
2 changes: 1 addition & 1 deletion ...leryRP/stable/2022-08-03/examples/communityGalleryExamples/CommunityGalleryImage_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"location": "myLocation",
"name": "myGalleryImageName",
"type": "Microsoft.Compute/Locations/CommunityGalleryImage",
"type": "Microsoft.Compute/locations/communityGalleryImage",
"identifier": {
"uniqueId": "/CommunityGalleries/publicGalleryName/Images/myGalleryImageName"
}
Expand Down
2 changes: 1 addition & 1 deletion ...e/GalleryRP/stable/2022-08-03/examples/communityGalleryExamples/CommunityGallery_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"body": {
"location": "myLocation",
"name": "publicGalleryName",
"type": "Microsoft.Compute/Locations/CommunityGallery",
"type": "Microsoft.Compute/locations/communityGallery",
"identifier": {
"uniqueId": "/CommunityGalleries/publicGalleryName"
},
Expand Down
2 changes: 1 addition & 1 deletion ...ft.Compute/GalleryRP/stable/2022-08-03/examples/galleryExamples/CommunityGallery_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"publisherContact": "pir@microsoft.com",
"eula": "eula",
"publicNames": [
"GalelryPublicName"
"GalleryPublicName"
],
"communityGalleryEnabled": true
}
Expand Down