Add API spec for ContainerApp Resiliency#25732
Merged
ms-zhenhua merged 1 commit intoAzure:release-app-Microsoft.App-2023-08-01-previewfrom Oct 11, 2023
Merged
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| CommonDefinitions.json | 2023-08-01-preview(1258735) | 2023-05-01(main) |
| CommonDefinitions.json | 2023-08-01-preview(1258735) | 2023-05-02-preview(main) |
️⚠️LintDiff: 18 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-08 | package-preview-2023-08(1258735) | package-preview-2023-08(release-app-Microsoft.App-2023-08-01-preview) |
[must fix]The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
Missing identifier id in array item property Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L620 |
|
Missing identifier id in array item property Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L787 |
|
Missing identifier id in array item property Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1108 |
|
Top level property names should not be repeated inside the properties bag for ARM resource 'Certificate'. Properties [properties.type] conflict with ARM top level properties. Please rename these. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1178 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L156 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L230 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L350 |
|
| Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L731 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L747 |
|
| Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L929 |
|
| Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1036 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1087 |
|
| Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1183 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1187 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1259 |
|
| Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1325 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1329 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
from
1ad045f to
ee5cc7c
Compare
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
from
ee5cc7c to
d9aa241
Compare
AzureRestAPISpecReview
added
ARMChangesRequested
BreakingChangeReviewRequired
|
Please address or respond to feedback from the ARM API reviewer. |
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
2 times, most recently
from
3bd01c6 to
a0b3561
Compare
vturecek
requested changes
Sep 19, 2023
...ication/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Envoy continuously checks endpoints in the background to either eject in case of failure or return to service after resuming normal operation. Can we update the description so it's clear that this can result in both new ejections as well as hosts being returned to service? Also, let's add the default interval in the description (10 seconds in Envoy).
Member
Author
There was a problem hiding this comment.
The description already references return to service. Is there a way you'd like it called out more explicitly? I know we tend to hide envoy from end-users so I didn't want to reference anything envoy related directly.
This is also the only place where we would have a default, isn't it? Is it worth calling out or should we enforce that customers always set it?
Member
There was a problem hiding this comment.
The description already references return to service
It's not just return to service, it can also eject a replica from service. Maybe something like:
"The time interval between endpoint checks. This can result in opening the circuit breaker if the check fails as well as closing the circuit breaker if the check succeeds. Defaults to 10s."
Member
Author
There was a problem hiding this comment.
Gotcha, makes sense. Updated.
Member
|
FYI - I think the breaking change detection is wrong here. This does not seem to be a breaking change. @halspang there is a review meeting scheduled (on your behalf) for Thursday, September 28 at 5 pm. So any feedback here needs to be addressed before that meeting. |
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
4 times, most recently
from
aa83511 to
a617df1
Compare
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
2 times, most recently
from
64d6721 to
20b47e4
Compare
raosuhas
added
the
WaitForARMFeedback
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
from
f66685c to
0892eb0
Compare
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ms-zhenhua
reviewed
Oct 10, 2023
specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/AppResiliency.json
Outdated
Show resolved
Hide resolved
...ication/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
...ication/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
...ication/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
Contributor
|
please fix error in https://github.com/Azure/azure-rest-api-specs/pull/25732/checks?check_run_id=17548183693, then re-add MergeRequest label |
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
from
0892eb0 to
b5b4e69
Compare
Signed-off-by: Hal Spang <halspang@microsoft.com>
halspang
force-pushed
the
app-resiliency-2023-08-01-preview
branch
from
b5b4e69 to
1258735
Compare
Member
Author
|
/pr RequestMerge |
ms-zhenhua
approved these changes
Oct 11, 2023
ms-zhenhua
merged commit 65d5a53
into
Azure:release-app-Microsoft.App-2023-08-01-preview
zizw123
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
sjanamma
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate * update tests for jobs * update tests for jobs * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.