Remove iotsecurity apis from public repo#25686
Merged
visingla-ms merged 2 commits intoSep 25, 2023
Merged
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| defenderSettings.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| deviceGroups.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| devices.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| locations.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| onPremiseSensors.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| operations.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| sensors.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| sites.json | 2021-02-01-preview(dd1105b) | 2021-02-01-preview(main) |
| types.json | 1.0(dd1105b) | 1.0(main) |
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/defenderSettings' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/defenderSettings/default' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L73:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/defenderSettings/default/packageDownloads' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L186:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/defenderSettings/default/downloadManagerActivation' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L222:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/locations/{iotDefenderLocation}/deviceGroups' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/locations/{iotDefenderLocation}/deviceGroups/{deviceGroupName}' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L79:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/locations/{iotDefenderLocation}/deviceGroups/{deviceGroupName}/devices' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/devices.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/locations/{iotDefenderLocation}/deviceGroups/{deviceGroupName}/devices/{deviceId}' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/devices.json#L89:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/locations' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/locations.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/locations/{iotDefenderLocation}' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/locations.json#L76:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/onPremiseSensors' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/onPremiseSensors.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/onPremiseSensors/{onPremiseSensorName}' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/onPremiseSensors.json#L73:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/onPremiseSensors/{onPremiseSensorName}/downloadActivation' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/onPremiseSensors.json#L192:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSecurity/onPremiseSensors/{onPremiseSensorName}/downloadResetPassword' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/onPremiseSensors.json#L235:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.IoTSecurity/operations' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/operations.json#L19:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sensors' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sensors/{sensorName}' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L73:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sensors/{sensorName}/downloadActivation' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L195:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sensors/{sensorName}/downloadResetPassword' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L238:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sensors/{sensorName}/triggerTiPackageUpdate' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L291:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sites' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sites.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.IoTSecurity/sites/default' removed or restructured? Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sites.json#L73:5 |
|
The new version is missing a definition that was found in the old version. Was 'DefenderSettingsModel' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L263:3 |
|
The new version is missing a definition that was found in the old version. Was 'DefenderSettingsProperties' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/defenderSettings.json#L263:3 |
|
The new version is missing a definition that was found in the old version. Was 'DeviceGroupModel' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L211:3 |
|
The new version is missing a definition that was found in the old version. Was 'DeviceGroupProperties' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L211:3 |
|
The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json#L211:3 |
|
The new version is missing a definition that was found in the old version. Was 'ResetPasswordInput' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/onPremiseSensors.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/onPremiseSensors.json#L289:3 |
|
The new version is missing a definition that was found in the old version. Was 'SensorModel' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L328:3 |
|
The new version is missing a definition that was found in the old version. Was 'SensorProperties' removed or renamed? New: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L37:3 Old: Microsoft.IoTSecurity/preview/2021-02-01-preview/sensors.json#L328:3 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| default | default(dd1105b) | default(main) |
️❌Avocado: 11 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: resource-manager/Microsoft.IoTSecurity/preview/2021-02-01-preview |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/DefenderSettings |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/DeviceGroups |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/Devices |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/Locations |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/OnPremiseSensors |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/Operations |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/Sensors |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: preview/2021-02-01-preview/examples/Sites |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: iotsecurity/resource-manager/common/1.0 |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: dd1105b0187b0fc4c0dcfc5a57cf38f72856104d/specification/iotsecurity/resource-manager |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
JeffreyRichter
approved these changes
Sep 6, 2023
JeffreyRichter
added
the
Approved-BreakingChange
openapi-workflow-bot
Bot
added
the
WaitForARMFeedback
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
Bot
removed
the
WaitForARMFeedback
Member
|
Please post on the TypeSpec channel to fix the Typespec validation |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
The failure in check "TypeSpec Validation" is a false positive bug in the tool. I approve merging this PR despite the failing check. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/pr RequestMerge |
visingla-ms
approved these changes
Sep 25, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Update package downloads public API * Remvoe the full api from public repo --------- Co-authored-by: Hassan Badir <hassanbadir@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have no customers that use our APIs, and want to take them off the public repo.