Skip to content

[Hub Generated] Publish private branch 'release-support-Microsoft.Support-2022-09-01-preview'#25630

Merged
raosuhas merged 60 commits intomainfrom
published/raghumunukutla/azure-rest-api-specs-pr/release-support-Microsoft.Support-2022-09-01-preview
Oct 4, 2023
Merged

[Hub Generated] Publish private branch 'release-support-Microsoft.Support-2022-09-01-preview'#25630
raosuhas merged 60 commits intomainfrom
published/raghumunukutla/azure-rest-api-specs-pr/release-support-Microsoft.Support-2022-09-01-preview

Conversation

@raghumunukutla
Copy link
Contributor

@raghumunukutla raghumunukutla commented Sep 1, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 27, 2023
@raosuhas
Copy link
Member

Approved suppression based on previous PR : https://github.com/Azure/azure-rest-api-specs-pr/pull/8647. New suppressions have been removed now

@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 27, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 27, 2023
@raych1 raych1 added Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript labels Sep 28, 2023
@raych1
Copy link
Member

raych1 commented Sep 28, 2023

Approved SDK BC for Go and JS based on the previous approval of the PR in private spec repo which has same reported SDK BC.

@raghumunukutla
Copy link
Contributor Author

/pr RequestMerge

@raosuhas
Copy link
Member

Lint errors are failing incorrectly approving this

@raosuhas raosuhas enabled auto-merge (squash) September 29, 2023 22:43
@raosuhas raosuhas merged commit 99b27b1 into main Oct 4, 2023
@raosuhas raosuhas deleted the published/raghumunukutla/azure-rest-api-specs-pr/release-support-Microsoft.Support-2022-09-01-preview branch October 4, 2023 04:07
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
…port-2022-09-01-preview' (#25630)

* First set of changes

* Changes for adding examples

* Minor change

* Changes as per comments

* Change to update swagger

* Changes for handling lintdiff errors

* Minor change

* Changes as per PR comments

* More changes

* More changes

* Adds base for updating Microsoft.Support from version stable/2020-04-01 to version 2022-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* Changes for new preview api version

* Changes as per PR comments

* Minor change

* Changes for adding File attachment related paths, definitions and examples

* Changes as per review comments

* Changes as per PR comments

* More cahnges as per PR comments

* Changes as per PR comments from ARM team

* Changes for adding a new property as part of support ticket details model and updates for file properties

* Fixed duplicate operation Ids

* Fixing intendation

* Addressed all the errors by adding suppression rules and fixing the errors

* Changes for addressing PR comments

* Minor changes

* Addressed comments

* Minor change

* Fixed minor typo comments

* Minor fix

* Fixed prettier checks

* Changes as per checks

* Fixed PR comments

* Minor change and prettier check updates

* More cahges to address the errors from checks

* Changes as per checks

* Fixed few prettier checks

* More changes to fix model validation errors

* Minor fix

* Changes as per comments

* Adding a suppression for workspace getlist

* Some model changes and associated updates to the examples

* Changes to fix errors from checks

* Changes to fix errors from checks

* Minor fixes in examples

* Changes for addressing comments

* Changes to address check failures

* Changes to address multi level nesting comment

* Fixing prettier check and minor fix

* Changes as per new comments

* Changes to remove suppression at file level

* Changes for removing supression rules at file level

* Changes to apply suppression rule to the definition wherever applicable

* Removing couple of suppression rules as they are taken care for new api

* Changes to suppress TopLevelResourcesListBySubscription for fileworkspaces

* Reverting the suppression rule change

* Changing suppression code

---------

Co-authored-by: Vijaya Munukutla <vimunuku@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments