Conversation
…01 to version 2022-09-01-preview
…odel and updates for file properties
Member
|
Approved suppression based on previous PR : https://github.com/Azure/azure-rest-api-specs-pr/pull/8647. New suppressions have been removed now |
Member
|
Approved SDK BC for Go and JS based on the previous approval of the PR in private spec repo which has same reported SDK BC. |
Contributor
Author
|
/pr RequestMerge |
Member
|
Lint errors are failing incorrectly approving this |
raosuhas
approved these changes
Sep 29, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Oct 4, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…port-2022-09-01-preview' (#25630) * First set of changes * Changes for adding examples * Minor change * Changes as per comments * Change to update swagger * Changes for handling lintdiff errors * Minor change * Changes as per PR comments * More changes * More changes * Adds base for updating Microsoft.Support from version stable/2020-04-01 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Changes for new preview api version * Changes as per PR comments * Minor change * Changes for adding File attachment related paths, definitions and examples * Changes as per review comments * Changes as per PR comments * More cahnges as per PR comments * Changes as per PR comments from ARM team * Changes for adding a new property as part of support ticket details model and updates for file properties * Fixed duplicate operation Ids * Fixing intendation * Addressed all the errors by adding suppression rules and fixing the errors * Changes for addressing PR comments * Minor changes * Addressed comments * Minor change * Fixed minor typo comments * Minor fix * Fixed prettier checks * Changes as per checks * Fixed PR comments * Minor change and prettier check updates * More cahges to address the errors from checks * Changes as per checks * Fixed few prettier checks * More changes to fix model validation errors * Minor fix * Changes as per comments * Adding a suppression for workspace getlist * Some model changes and associated updates to the examples * Changes to fix errors from checks * Changes to fix errors from checks * Minor fixes in examples * Changes for addressing comments * Changes to address check failures * Changes to address multi level nesting comment * Fixing prettier check and minor fix * Changes as per new comments * Changes to remove suppression at file level * Changes for removing supression rules at file level * Changes to apply suppression rule to the definition wherever applicable * Removing couple of suppression rules as they are taken care for new api * Changes to suppress TopLevelResourcesListBySubscription for fileworkspaces * Reverting the suppression rule change * Changing suppression code --------- Co-authored-by: Vijaya Munukutla <vimunuku@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.