Revert prettier update from https://github.com/Azure/azure-rest-api-specs/pull/25496#25606
Merged
Conversation
This broke the running of prettier on the json files in the repo because the prettier-swagger-plugin no longer compiles as there seems to be a breaking change between prettier 2.x and 3.x. We will need to further investigate this if we want to take this change.
weshaggard
requested review from
konrad-jamrozik and
mikeharder
as code owners
Next Steps to Merge |
Swagger Validation Report
|
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
benbp
approved these changes
Aug 30, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
This broke the running of prettier on the json files in the repo because the prettier-swagger-plugin no longer compiles as there seems to be a breaking change between prettier 2.x and 3.x. We will need to further investigate this if we want to take this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #25496
This broke the running of prettier on the json files in the repo because the prettier-swagger-plugin no longer compiles as there seems to be a breaking change between prettier 2.x and 3.x. We will need to further investigate this if we want to take this change.