Skip to content

Comments

ExpressRoute swagger examples#2557

Closed
karthikananth wants to merge 3 commits intoAzure:masterfrom
karthikananth:ExpressRouteSwaggerExamples
Closed

ExpressRoute swagger examples#2557
karthikananth wants to merge 3 commits intoAzure:masterfrom
karthikananth:ExpressRouteSwaggerExamples

Conversation

@karthikananth
Copy link
Member

@karthikananth karthikananth commented Feb 28, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Feb 28, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3038

@AutorestCI
Copy link

AutorestCI commented Feb 28, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2345

@alvadb
Copy link

alvadb commented Feb 28, 2018

Please review the following errors and fix or comment on them.
breaking changes: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/347156842
model: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/347156841

@alvadb
Copy link

alvadb commented Mar 9, 2018

I haven't seen any activity for this PR in over a week. Please let me know if this PR is still valid.

@karthikananth
Copy link
Member Author

karthikananth commented Mar 9, 2018 via email

@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

1 similar comment
@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

@alvadb
Copy link

alvadb commented Apr 10, 2018

Hi, I know there was an issue with the examples. Have those been checked in yet?

@karthikananth
Copy link
Member Author

@vinayada can you please look into this ?

@lmazuel
Copy link
Member

lmazuel commented Jun 27, 2018

Hi @karthikananth ! I'm now working with you on that PR, since Alva is not in our team anymore.
There was several release of Network since the beginning of this PR, would it be possible for you to copy your examples to all api-versions, or maybe just move them from 2018-01 to the latest one?
Thanks!

@lmazuel
Copy link
Member

lmazuel commented Jul 6, 2018

@MikhailTryakhov for guidance please

@lmazuel lmazuel added the Network label Jul 6, 2018
@MikhailTryakhov
Copy link
Contributor

@karthikananth I recommend to follow documentation :)

@lmazuel
Copy link
Member

lmazuel commented Jul 30, 2018

Closing for inactivity. Please re-open the PR following guidance of @MikhailTryakhov. Thank you.

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1409

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpa0e1qtgf/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpa0e1qtgf/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.71', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4283).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.71->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06"} .
Processing batch task - {"tag":"package-2018-04"} .
Processing batch task - {"tag":"package-2018-05"} .
Failure during batch task - {"tag":"package-2018-05"} -- Error: [Exception] No input files provided.

Use --help to get help information..
[Exception] No input files provided.

Use --help to get help information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants