Skip to content

VI stable/2024-01-01 - AMSless accounts #25440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 17, 2023
Merged

VI stable/2024-01-01 - AMSless accounts #25440

merged 9 commits into from
Oct 17, 2023

Conversation

@dazilb
Copy link
Contributor

@dazilb dazilb commented Aug 22, 2023 •
edited by omerhaimov
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️❌Breaking Change(Cross-Version): 8 Errors, 8 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
vi.json 2024-01-01(63e0e4f) 2022-08-01(main)
vi.json 2024-01-01(63e0e4f) 2022-07-20-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.VideoIndexer/locations/{location}/userClassicAccounts' removed or restructured?
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L490:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.VideoIndexer/locations/{location}/classicAccounts/{accountName}' removed or restructured?
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L536:5
❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MediaServicesForPutRequest' removed or renamed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L528:3
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L710:3
❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MediaServicesForPatchRequest' removed or renamed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L528:3
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L710:3
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'LocationParameter' removed or renamed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L1015:3
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L1268:3
❌ 1011 - AddingResponseCode The new version adds a response code '201'.
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L331:11
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'mediaServices' renamed or removed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L595:7
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L777:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'mediaServices' renamed or removed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L647:7
Old: Microsoft.VideoIndexer/stable/2022-08-01/vi.json#L829:7


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.VideoIndexer/locations/{location}/userClassicAccounts' removed or restructured?
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L490:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.VideoIndexer/locations/{location}/classicAccounts/{accountName}' removed or restructured?
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L536:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MediaServicesForPutRequest' removed or renamed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L528:3
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L794:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MediaServicesForPatchRequest' removed or renamed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L528:3
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L794:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'LocationParameter' removed or renamed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L1015:3
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L1383:3
⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L331:11
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'mediaServices' renamed or removed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L595:7
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L861:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'mediaServices' renamed or removed?
New: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L647:7
Old: Microsoft.VideoIndexer/preview/2022-07-20-preview/vi.json#L913:7
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 4 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2024-01 package-2024-01(63e0e4f) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generaterestrictedvieweraccesstoken' in:'Generate_RestrictedViewerAccessToken'. Consider updating the operationId
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L475
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L490
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L493
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L499


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L58
❌ RepeatedPathInfo The 'accountName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L309
❌ DeleteResponseCodes An async DELETE operation must set ''x-ms-long-running-operation' : true'.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L359
❌ LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L365
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L384
❌ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L911
❌ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L951
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L90
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L93
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L135
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L138
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L174
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L177
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L180
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L211
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L214
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L220
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L252
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L255
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L261
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L304
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L307
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L313
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L368
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L371
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L377
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L409
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L433
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L436
️❌Avocado: 2 Errors, 0 Warnings failed [Detail]
Rule Message
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.VideoIndexer/locations/{}/userClassicAccounts is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/vi/resource-manager/readme.md
json: Microsoft.VideoIndexer/stable/2022-08-01/vi.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.VideoIndexer/locations/{}/classicAccounts/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/vi/resource-manager/readme.md
json: Microsoft.VideoIndexer/stable/2022-08-01/vi.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking



️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 0a25ea9. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-videoindexer [View full logs]  [Release SDK Changes] 
    info	[Changelog]   - Initial Release
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 0a25ea9. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-vi [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 0a25ea9. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/videoindexer/armvideoindexer [View full logs]  [Release SDK Changes] 
    info	[Changelog] This is a new package
info	[Changelog]
️❌ azure-sdk-for-js failed [Detail]
  • ❌Failed [Logs]Release - Generate from 0a25ea9. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Error:
cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for readme file: "specification/vi/resource-manager/readme.md":
cmderr	[automation_generate.sh] [ERROR] Err: Error: Unexpected package name: vi
cmderr	[automation_generate.sh] [ERROR] Stderr: "undefined"
cmderr	[automation_generate.sh] [ERROR] Stdout: "undefined"
cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Unexpected package name: vi
cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:123:31)
cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
cmderr	[automation_generate.sh] [ERROR]     at processTicksAndRejections (node:internal/process/task_queues:96:5)"
  • info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 0a25ea9. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️❌ azure-powershell failed [Detail]
  • ❌Pipeline Framework Failed [Logs]Release - Generate from 0a25ea9. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.vi.DefaultTag [View full logs]  
    error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.vi.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/videoindexer/armvideoindexer https://apiview.dev/Assemblies/Review/3aba9008a12a4eeab740a131509f3b9b
Java azure-resourcemanager-vi https://apiview.dev/Assemblies/Review/83b34ec5f5094def8c706d77aa403edc
JavaScript vi https://apiview.dev/Assemblies/Review/7c90911492f345e5a83bbc6bb220f4ae

This was referenced Aug 22, 2023
Closed
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 22, 2023
This was referenced Aug 22, 2023
Closed
Closed
Closed
@omerhaimov
1. Change media services to storage services.
c73061f 
2. Remove Error Codes from examples and swagger.
@omerhaimov omerhaimov changed the title [Hub Generated] Review request for Microsoft.VideoIndexer to add version preview/2022-07-20-preview VI stable/2024-01-01 - AMSless accounts Aug 27, 2023
@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Aug 27, 2023

Hi @dazilb! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2023
@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Aug 27, 2023

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 18, 2023

Hi, @dazilb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 18, 2023

Hi, @dazilb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 18, 2023

Hi, @dazilb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

3 similar comments
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 18, 2023

Hi, @dazilb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 18, 2023

Hi, @dazilb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 18, 2023

Hi, @dazilb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@omerhaimov omerhaimov added MergeRequested and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Oct 16, 2023
@rkmanda
Copy link
Member

rkmanda commented Oct 16, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 16, 2023

Azure Pipelines successfully started running 3 pipeline(s).

@rkmanda
Copy link
Member

rkmanda commented Oct 16, 2023

checks are queued. Will merge it after they pass

@rkmanda rkmanda merged commit 0a25ea9 into main Oct 17, 2023
@rkmanda rkmanda deleted the dazilb-vi-Microsoft.VideoIndexer-2024-01-01 branch October 17, 2023 00:51
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 17, 2023

Swagger pipeline restarted successfully, please wait for status update in this comment.

This was referenced Oct 17, 2023
Closed
Closed
Closed
Closed
Closed
jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
@dazilb @omerhaimov @jnlycklama
VI stable/2024-01-01 - AMSless accounts (#25440)
06c862b 
* Adds base for updating Microsoft.VideoIndexer from version preview/2022-07-20-preview to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* 1. Change media services to storage services.
2. Remove Error Codes from examples and swagger.

* fix missing example

* fix date of examples

* fix example dates

* fix user assigned identity

* add 201 response code

---------

Co-authored-by: Omer Haimovich <[email protected]>
zman-ms pushed a commit that referenced this pull request Jan 10, 2024
@dazilb @omerhaimov @zman-ms
VI stable/2024-01-01 - AMSless accounts (#25440)
aeb5a8c 
* Adds base for updating Microsoft.VideoIndexer from version preview/2022-07-20-preview to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* 1. Change media services to storage services.
2. Remove Error Codes from examples and swagger.

* fix missing example

* fix date of examples

* fix example dates

* fix user assigned identity

* add 201 response code

---------

Co-authored-by: Omer Haimovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkmanda rkmanda rkmanda approved these changes

+1 more reviewer

@omerhaimov omerhaimov omerhaimov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rkmanda rkmanda

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dazilb @rkmanda @omerhaimov @JeffreyRichter @AzureRestAPISpecReview @sjanamma