-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Update subscription creation ARM API in Microsoft.Subscription RP #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
3919ecd
19a919b
d799d74
5d44b15
931a5a3
a4c75bf
ae55fa6
7feabda
f64198c
85443e0
cef2be0
882c078
2a4555b
549bb10
d3a8186
95fc8cf
782fa82
bc4c145
8c9aef6
5d31f58
05e0359
9a5ddb0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "parameters": { | ||
| "scope": "/providers/Microsoft.Billing/billingAccounts/a460e639-9c9b-4b58-9046-1120b22c7dc1/", | ||
| "api-version": "2018-03-01-preview", | ||
| "body": { | ||
| "properties": { | ||
| "offerType": "MS-AZR-0017P", | ||
| "displayName": "Test Ea Azure Sub", | ||
| "owners": [ | ||
| { | ||
| "tenantId": "73f7ab6e-cfa0-42be-b506-be6e77c2700c", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's also change this to 05053bdf-7e6a-4f96-854f-1dae531c170b - we likely won't allow owners from different tenants to be assigned owner on the subscription. |
||
| "objectId": "973034ff-acb7-409c-b731-e789672c7b31" | ||
| }, | ||
| { | ||
| "tenantId": "05053bdf-7e6a-4f96-854f-1dae531c170b", | ||
| "objectId": "67439a9e-8519-4016-a630-f5f805eba567" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "/providers/Microsoft.Subscription/subscriptionOperations/aeb76128-ebde-4f5a-a9ed-e7bbf2dbc994?api-version=2018-03-01-preview", | ||
| "Retry-After": "60" | ||
| } | ||
| }, | ||
| "200": { | ||
| "body": { | ||
| "subscriptionLink": "/subscriptions/c03acf6e-5295-44c2-92d3-cb1daa4c701c" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-03-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "Microsoft.Subscription/createOperation/action", | ||
| "display": { | ||
| "provider": "Microsoft Subscription", | ||
| "resource": "Resources", | ||
| "operation": "Create a subscription", | ||
| "description": "Create an Azure subscription." | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we rename this file to "getSubscriptionOperations.json"? I think we'll also want to return (recently) completed operations for a better developer experience.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| "parameters": { | ||
| "api-version": "2018-03-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/providers/Microsoft.Subscription/subscriptionOperations/c03acf6e-5295-44c2-92d3-cb1daa4c701c", | ||
| "status": "Pending", | ||
| "statusDetail": "Subscription Creation in Progress" | ||
| }, | ||
| { | ||
| "id": "/providers/Microsoft.Subscription/subscriptionOperations/d46dcd37-f8b3-43a4-aed6-41de9131412d", | ||
| "status": "Pending", | ||
| "statusDetail": "Subscription Creation in Progress" | ||
| }, | ||
| { | ||
| "id": "/providers/Microsoft.Subscription/subscriptionOperations/54e3cde0-2420-451c-969d-f538d5349834", | ||
| "status": "Pending", | ||
| "statusDetail": "Subscription Creation in Progress" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the examples to reflect your latest change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done