feat: fragment support swagger change#25314
Merged
Sneezry merged 1 commit intoAzure:dev-appplatform-2023-09-01-previewfrom Aug 16, 2023
Merged
Conversation
|
Hi, @guitarsheng! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=380190&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️⚠️SDK Breaking Change Tracking warning [Detail]
Breaking Changes Tracking
⚠️azure-sdk-for-go - sdk/resourcemanager/appplatform/armappplatform - 2.0.0-beta.2+ Field `Instances`, `ResourceRequests` of struct `DevToolPortalProperties` has been removed
⚠️azure-sdk-for-js - @azure/arm-appplatform - 3.0.0-beta.2+ Class AppPlatformManagementClient has a new signature
+ Interface DeploymentsListForClusterNextOptionalParams no longer has parameter version
+ Interface DeploymentsListNextOptionalParams no longer has parameter version
+ Type of parameter addonConfigs of interface AppResourceProperties is changed from {
[propertyName: string]: {
[propertyName: string]: Record;
};
} to {
[propertyName: string]: Record;
}
+ Type of parameter addonConfigs of interface DeploymentSettings is changed from {
[propertyName: string]: {
[propertyName: string]: Record;
};
} to {
[propertyName: string]: Record;
}
+ Type of parameter bindingParameters of interface BindingResourceProperties is changed from {
[propertyName: string]: Record;
} to {
[propertyName: string]: string;
}⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-appplatform - 8.0.0+ Model DevToolPortalProperties no longer has parameter instances + Model DevToolPortalProperties no longer has parameter resource_requests
️🔄 azure-powershell inProgress [Detail]
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️🔄 azure-sdk-for-java inProgress [Detail]
️🔄 azure-sdk-for-net-track2 inProgress [Detail]
️🔄 azure-sdk-for-js inProgress [Detail]
️🔄 azure-sdk-for-go inProgress [Detail]
️🔄 azure-resource-manager-schemas inProgress [Detail]
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @guitarsheng! The automation detected breaking changes in this pull request. As a result, it added the
|
This was referenced Aug 15, 2023
Sneezry
approved these changes
Aug 16, 2023
yuwzho
approved these changes
Aug 16, 2023
Member
|
/azp run |
Next Steps to Merge
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
yuwzho
pushed a commit
that referenced
this pull request
Aug 24, 2023
yuwzho
pushed a commit
that referenced
this pull request
Aug 24, 2023
rkmanda
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat: fragment support swagger change (#25314) * Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (#25322) * support war file deployment (#25312) Co-authored-by: Yi Li <yili7@microsoft.com> * Fix exmaple for api portal api try-out feature (#25337) * Add property `autoSync` in `KeyVaultCertificateProperties` (#25331) * Add gateway apm reference (#25408) * Add expand parameter for list deployment (#25411) * Add expand parameter for list deployments API (#25471) * change order of expand (#25587) * Update readme.go.md (#25634) * Update readme.go.md * Update readme.python.md * Update readme.ruby.md * Revert api portal try out feature (#25677) Fix exmaple for api portal api try-out feature (#25337)" * add API to list all server versions (#25720) * add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <yili7@microsoft.com> * use enum for autoSync (#25722) * Update appplatform.json (#25724) * certificate - rename enum (#25723) * use enum for autoSync * rename enum * rename enum --------- Co-authored-by: guitarsheng <85543793+guitarsheng@users.noreply.github.com> Co-authored-by: Mason Chen <jiec@microsoft.com> Co-authored-by: Yi Li <109205537+yilims@users.noreply.github.com> Co-authored-by: Yi Li <yili7@microsoft.com> Co-authored-by: Jeff <1830237+domainname@users.noreply.github.com> Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat: fragment support swagger change (#25314) * Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (#25322) * support war file deployment (#25312) Co-authored-by: Yi Li <yili7@microsoft.com> * Fix exmaple for api portal api try-out feature (#25337) * Add property `autoSync` in `KeyVaultCertificateProperties` (#25331) * Add gateway apm reference (#25408) * Add expand parameter for list deployment (#25411) * Add expand parameter for list deployments API (#25471) * change order of expand (#25587) * Update readme.go.md (#25634) * Update readme.go.md * Update readme.python.md * Update readme.ruby.md * Revert api portal try out feature (#25677) Fix exmaple for api portal api try-out feature (#25337)" * add API to list all server versions (#25720) * add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <yili7@microsoft.com> * use enum for autoSync (#25722) * Update appplatform.json (#25724) * certificate - rename enum (#25723) * use enum for autoSync * rename enum * rename enum --------- Co-authored-by: guitarsheng <85543793+guitarsheng@users.noreply.github.com> Co-authored-by: Mason Chen <jiec@microsoft.com> Co-authored-by: Yi Li <109205537+yilims@users.noreply.github.com> Co-authored-by: Yi Li <yili7@microsoft.com> Co-authored-by: Jeff <1830237+domainname@users.noreply.github.com> Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Getting help
and https://aka.ms/ci-fix.