Skip to content

support war file deployment #25312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zhe Li (Sneezry) merged 3 commits into from
Aug 16, 2023
Merged

support war file deployment #25312

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ab9f6a
support war file deployment
Aug 15, 2023
1d374a8
WarUploadedUserSourceInfo extend UploadedUserSourceInfo
yilims Aug 16, 2023
19fc664
fix json format
yilims Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...atform/resource-manager/Microsoft.AppPlatform/preview/2023-09-01-preview/appplatform.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12311,6 +12311,22 @@
},
"x-ms-discriminator-value": "Jar"
},
"WarUploadedUserSourceInfo": {
"description": "Uploaded War binary for a deployment",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/JarUploadedUserSourceInfo"

@Sneezry Zhe Li (Sneezry) Aug 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UploadedUserSourceInfo?

@yilims yilims (yilims) Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

war file deployment has all the properties of JarUploadedUserSourceInfo, ex: runtimeVersion & jvmOptions.

Are you proposing to use UploadedUserSourceInfo and add runtimeVersion & jvmOptions as properties in WarUploadedUserSourceInfo?

@Sneezry Zhe Li (Sneezry) Aug 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, please use UploadedUserSourceInfo and add runtimeVersion & jvmOptions as properties in WarUploadedUserSourceInfo

}
],
"properties": {
"serverVersion": {
"description": "Server version, currently only Apache Tomcat is supported",
"type": "string"
}
},
"x-ms-discriminator-value": "War"
},
"SourceUploadedUserSourceInfo": {
"description": "Uploaded Java source code binary for a deployment",
"type": "object",
Expand Down