Skip to content

EGv2 auth to SharedAccessKey prefix#25299

Merged
lmazuel merged 1 commit intoAzure:mainfrom
l0lawrence:update_auth
Sep 28, 2023
Merged

EGv2 auth to SharedAccessKey prefix#25299
lmazuel merged 1 commit intoAzure:mainfrom
l0lawrence:update_auth

Conversation

@l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Aug 14, 2023

No description provided.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 14, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
EventGrid.json 2023-06-01-preview(7f886be) 2023-06-01-preview(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.5) new version base version
package-2023-06-01-preview package-2023-06-01-preview(7f886be) package-2023-06-01-preview(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L56


The following errors/warnings exist before current PR submission:

Rule Message
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L48
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L64
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L73
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L121
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L121
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L122
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L128
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L135
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L190
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L191
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L197
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L204
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L249
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L250
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L256
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L263
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L308
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L309
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L315
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L322
⚠️ SchemaNamesConvention Schema name should be Pascal case.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L409
⚠️ SchemaNamesConvention Schema name should be Pascal case.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L443
⚠️ SchemaNamesConvention Schema name should be Pascal case.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L456
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L501
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
Rule Message
❌ INVALID_TYPE Expected type but found type object
Url: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L93:22
ExampleUrl: preview/2023-06-01-preview/examples/publish.json#L24:16
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Aug 14, 2023

Hi, @l0lawrence! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

    • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 14, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 45634ef. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/eventgrid/Azure.Messaging.EventGrid/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.Messaging.EventGrid [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 45634ef. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/eventgrid/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh]  New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️azure-eventgrid [View full logs]  [Release SDK Changes] 
      info	[Changelog] data-plan skip changelog generation temporarily
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 14, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Python azure-eventgrid https://apiview.dev/Assemblies/Review/41f74a9fad2f411cb8b044781cb5d1c7
    .Net Azure.Messaging.EventGrid There is no API change compared with the previous version

    @azure-sdk azure-sdk mentioned this pull request Aug 14, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Aug 14, 2023
    Closed
    @l0lawrence l0lawrence marked this pull request as ready for review August 15, 2023 18:03
    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    2 similar comments
    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    3 similar comments
    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 4, 2023 •
    edited
    Loading

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    2 similar comments
    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    2 similar comments
    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    microsoft-github-policy-service bot commented Sep 4, 2023

    Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @lmazuel lmazuel merged commit 45634ef into Azure:main Sep 28, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 28, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    This was referenced Sep 28, 2023
    Closed
    Closed
    jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
    @l0lawrence @jnlycklama
    update with new changes (#25299)
    62fbb30
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @lmazuel lmazuel lmazuel approved these changes

    @Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

    @ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

    Assignees

    @lmazuel lmazuel

    Labels

    data-plane

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @l0lawrence @lmazuel @AzureRestAPISpecReview