Skip to content

Adding Swagger for AmlServerless RPaaS #25235

Closed
haritha-bendapudi wants to merge 13 commits into
Azure:RPSaasDevfrom
haritha-bendapudi:main
Closed

Adding Swagger for AmlServerless RPaaS #25235
haritha-bendapudi wants to merge 13 commits into
Azure:RPSaasDevfrom
haritha-bendapudi:main

Conversation

@haritha-bendapudi
Copy link
Copy Markdown

@haritha-bendapudi haritha-bendapudi commented Aug 9, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

vedkale and others added 13 commits August 7, 2023 17:58
…version preview/2023-04-25-preview (Azure#24970)

* update name pattern and change instanceview

* update examples

* add ExtensionsResourceInstanceView

* change extensions instance view

* undo ref change

* update times in examples

* Remove 04-25-2024 from the public specs repo. Will add these specs to the private repo

* Update readme.md

* Update readme.md

---------

Co-authored-by: Ved Kale <vedkale@microsoft.com>
* adding new folder 2023-04-02

* readme section for 2023-04-02

* changing version number in folder 2023-04-02

* Adding new disk property - LastOwnershipUpdateTime (Azure#25039)

* Added lastownership field

* Added to existing DIsk_Get.json example

* Swagger changes for elastic san import and export feature (Azure#24953)

* swagger changes for elastic san import and export feature

* fixing API version in swagger examples

* adding reference to examples

* fixing examples

* Dev/carloshehe/last ownership update time (Azure#25160)

* Added lastownership field

* Added to existing DIsk_Get.json example

* New description

* Using Vikram's suggestion for description

* Fixed bad casing

---------

Co-authored-by: carlos6125 <140001684+carlos6125@users.noreply.github.com>
Co-authored-by: PrambMS <136007667+PrambMS@users.noreply.github.com>
* New AO5GC 1.0 service - 2023-05-15-preview

* Addressed the Swagger LintDiff errors

* Addressed the Swagger ModelValidation errors

* Addressed long running operation LintDiff errors

* Formatted the *.tsp files

* Removed the common.json and added the parameters to the networkfunction.json

* Updated the Type Script to address the Swagger API validations

* Addressed the validation errors

* Updated the examples and formatted the *.tsp files

* Update specification/mpcnetworkfunction/resource-manager/readme.typescript.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/mpcnetworkfunction/mpcnetworkfunction.Management/tspconfig.yaml

Co-authored-by: Mike Harder <mharder@microsoft.com>

* Updated the common types version to v3

* Updated the networkfunction TypeSpec file to the latest version and generated the Swagger API

---------

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
…add version stable/2023-07-01 (Azure#25151)

* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-06-01 to version 2023-07-01

* Updates readme

* Updates API version in new specs and examples

* feat: add range min/max for custom node config GA changes for 2023-07-01 API (Azure#25068)

Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>

* update readmes (Azure#25048)

* add force upgrade option (Azure#25100)

* add force upgrade option

* update msg

---------

Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>

---------

Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Co-authored-by: Wenjun Gao <wenjungaoat@gmail.com>
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
- Fixes Azure#24791
- Fixes Azure#24790
- Ensures developers can successfully work on both Linux and Windows
- Consistent with other repos like `microsoft/typespec` and `azure/azure-sdk-for-js`
- Required for node-based tools like `tsp format` which assume LF
* change sessionId type from int to string

* modify related code
- Fixes Azure#25212 
- Files were committed with CRLF instead of LF
- Should be prevented going forward due to settings in `.gitattributes`, but clients can always force add files with CRLF
- Related to Azure#24817
- Issue seen before in Azure#4746 and Azure#3786
…4755)

* added july 2023 api version

* fixed few changes

* Prettier

* Avocado

* Updated examples

* fixed examples

* added changes

* addressed review comments

* addressed review comment

* fixed build issue

* fixed model validation error

* addressed comment

* addressed review comments

* few minor changes

* added minor changes

* prettier

* addressed review comments
* `securitycenter` fix yaml

* fix path in readme.md
@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @haritha-bendapudi! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Aug 28, 2023

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has non-breaking changes (label: NewApiVersionRequired). You must introduce a new API version with these changes instead of modifying existing one. See the PR description for help.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    3 similar comments
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    6 similar comments
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @haritha-bendapudi. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.