Skip to content

[Compute] Create a folder for compute 2018-04-01 API version#2519

Merged
lmazuel merged 1 commit into
Azure:compute-2018-04from
hyonholee:master
Feb 23, 2018
Merged

[Compute] Create a folder for compute 2018-04-01 API version#2519
lmazuel merged 1 commit into
Azure:compute-2018-04from
hyonholee:master

Conversation

@hyonholee
Copy link
Copy Markdown
Contributor

@hyonholee hyonholee commented Feb 20, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Feb 20, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2053

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Feb 20, 2018

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 142, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 283, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 551, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1010, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 821, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_compute-2018-04
  stderr: 'To https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-go.git
 ! [rejected]        restapi_auto_compute-2018-04 -> restapi_auto_compute-2018-04 (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-go.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

@jianghaolu jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 21, 2018
Copy link
Copy Markdown
Contributor

@jianghaolu jianghaolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New API with minor changes. Approved from SDK side.

@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Feb 22, 2018

@hyonholee Do you authorize me to update this PR with the correct updated Readme?
If not, could you be do this.
Thank you.

@hyonholee
Copy link
Copy Markdown
Contributor Author

@lmazuel No, please do not update readme.md file. This is a preliminary PR for upcoming API. We still want to generate a client library from 2017-12-01 version, but Networking team asked us to create 2018-04-01 folder in order to send their PR for modifying compute.json file. When CRP enables 2018-04-01 API, the networking team will test the 2018-04-01 API with their update and then update the readme.md file.

@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Feb 22, 2018

Thanks for the heads-up @hyonholee :)
All SDK owners, FYI @shahabhijeet @marstr @sarangan12 @amarzavery

@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Feb 22, 2018

@hyonholee After thinking about it, we usually don't check-in Swagger that are not ready for prod in "master". This creates documentation issue, and some customers are using directly the Swaggers. I think we should use a feature branch compute-2018-04 for that. This allows Network team to work on that as well (they used to feature branch). Thoughts?
@salameer for guidance.
Thanks!

@hyonholee
Copy link
Copy Markdown
Contributor Author

@lmazuel Thanks for feedback.
@salameer Could you create compute-2018-04 branch and redirect this PR to there?

@marstr marstr changed the base branch from master to compute-2018-04 February 23, 2018 00:20
@marstr
Copy link
Copy Markdown
Member

marstr commented Feb 23, 2018

I'm not @salameer, but ask and you shall receive. @hyonholee, your branch has been created, and your PR re-targeted.

@hyonholee
Copy link
Copy Markdown
Contributor Author

Thanks, could you merge this PR if there is no more issue? Our team will send more PR to compute-2018-04 branch. Thanks.

@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Feb 23, 2018

@jianghaolu is fine with the content, and I double-checked with @salameer, so merging.
@ravbhatnagar FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants