Skip to content

Swagger for Machine List, Get API#25178

Closed
sushmak295 wants to merge 32 commits into
Azure:mainfrom
sushmak295:FumingZhang-containerservice-Microsoft.ContainerService-2023-07-02-preview
Closed

Swagger for Machine List, Get API#25178
sushmak295 wants to merge 32 commits into
Azure:mainfrom
sushmak295:FumingZhang-containerservice-Microsoft.ContainerService-2023-07-02-preview

Conversation

@sushmak295
Copy link
Copy Markdown
Contributor

@sushmak295 sushmak295 commented Aug 4, 2023 •
edited by openapi-workflow-bot Bot
Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

FumingZhang and others added 12 commits July 31, 2023 10:17
@FumingZhang
Adds base for updating Microsoft.ContainerService/aks from version pr…
1bcdca4 
…eview/2023-06-02-preview to version 2023-07-02-preview
@FumingZhang
Updates readme
2f6ce2f
@FumingZhang
Updates API version in new specs and examples
888b2fd
@FumingZhang
update readmes (Azure#25049)
04926ec
@pdaru
add new field resourceUID to managed cluster properties (Azure#25069)
b743d5f 
* add new field resourceUID to managed cluster properties

https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp/pullrequest/8416789

* update description
@NickKeller
Mark guardrailsProfile Version as not required (Azure#25081)
83fa375 
* Mark guardrailsProfile Version as not required

* Run prettier

---------

Co-authored-by: Nick Keller <nickkeller@nickmsftlaptop.lan>
@jaiveerk
Swagger Changes for Multiple DNS Zones for Web App Routing (Azure#25064)
02dce2a 
* added web app routing changes for multiple dns zones

* modified examples
@jatakiajanvi12 @FumingZhang
Changes for unified azuremonitorprofile in Microsoft.ContainerService (…
74cfbc8 
…Azure#25063)

* Changes for unified azuremonitorprofile

* Update prettier changes

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

---------

Co-authored-by: Janvi Jatakia (from Dev Box) <jajataki@microsoft.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
@matthchr
Add cost analysis to AKS preview Swagger (Azure#25082)
870eba0
@wenjungaogaogao
update preview API to follow GA api - use one forceupgrade boolean in… (
288bcc1 
Azure#25099)

* update preview API to follow GA api - use one forceupgrade boolean instead of multiple overrides

* update msg

---------

Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
@norshtein
Mark trusted access role binding PUT and DELETE operation as async (A…
db24ef8 
…zure#25112)

* Mark trusted access role binding PUT and DELETE operation as async

* fix CI: update TA oepration's error to common type error
Swagger for Machine List, Get API
56a8381 
Related work items: #24759018
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Aug 4, 2023 •
edited
Loading

Swagger pipeline can not start as the pull request has merge conflicts.

1 similar comment
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Aug 4, 2023 •
edited
Loading

Swagger pipeline can not start as the pull request has merge conflicts.

@openapi-workflow-bot
Copy link
Copy Markdown

openapi-workflow-bot Bot commented Aug 4, 2023

Hi @sushmak295, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to Service API Toolset Introduction for details.
  • Please contact service focal contacts or Service API Toolset Support Channel if need further help.

    		•

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Aug 4, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot openapi-workflow-bot Bot added ShiftLeftViolation DoNotMerge <valid label in PR review process> use to hold merge after approval labels Aug 4, 2023
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot Bot commented Aug 4, 2023

    Hi, @sushmak295! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

    • @microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 4, 2023
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    microsoft-github-policy-service Bot commented Aug 4, 2023

    Thank you for your contribution sushmak295! We will review the pull request and get back to you soon.

    @azure-sdk azure-sdk mentioned this pull request Aug 4, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Aug 7, 2023
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 7, 2023
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot Bot commented Aug 7, 2023

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot Bot commented Aug 7, 2023

    Hi @sushmak295! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    @azure-sdk azure-sdk mentioned this pull request Aug 7, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Aug 7, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Aug 7, 2023
    Closed
    sushmak295 and others added 8 commits August 7, 2023 20:52
    swagger: machine api
    b97e09c
    @FumingZhang
    Update specification/containerservice/resource-manager/Microsoft.Cont…
    cdbe9ac 
    …ainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
    swagger: machine api
    a5f9dd3
    swagger: machine api
    2dd9ecb
    swagger: machine api
    bc85591
    swagger:machine api
    ebff7ab
    swagger:machine api
    0e91d6a
    swagger:machine api
    5dde315
    @sushmak295
    Copy link
    Copy Markdown
    Contributor Author

    sushmak295 commented Aug 9, 2023

    duplicate pr

    @sushmak295 sushmak295 closed this Aug 9, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @msyyc msyyc Awaiting requested review from msyyc

    @palma21 palma21 Awaiting requested review from palma21 palma21 is a code owner

    @weinong weinong Awaiting requested review from weinong

    @alvinli222 alvinli222 Awaiting requested review from alvinli222

    @matthchr matthchr Awaiting requested review from matthchr matthchr is a code owner

    @circy9 circy9 Awaiting requested review from circy9

    Assignees

    @rkmanda rkmanda

    Labels

    ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure CI-MissingBaseCommit customer-reported Issues that are reported by GitHub users external to the Azure organization. DoNotMerge <valid label in PR review process> use to hold merge after approval new-api-version resource-manager ShiftLeftViolation

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.