Base commit of SCOM MI PP 20230707 version#25171
Merged
Merged
Conversation
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-2023-07-07-preview | package-2023-07-07-preview(f0ed59c) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Scom/preview/2023-07-07-preview/scom.json#L7 |
||
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Operations_List Location: Microsoft.Scom/preview/2023-07-07-preview/scom.json#L122 |
||
| OperationId should contain the verb: 'setservercount' in:'Instances_Scale'. Consider updating the operationId Location: Microsoft.Scom/preview/2023-07-07-preview/scom.json#L461 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Hi, @RBANSALMS! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @RBANSALMS! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
|
Hi, @RBANSALMS, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
|
Hi @RBANSALMS, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
Contributor
Author
|
GitHub issue for finalizing name of the NameSpace for SDK: |
RBANSALMS
requested review from
jsntcy,
msyyc,
qiaozha and
tadelesh
as code owners
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
Contributor
Author
|
Link for Private Repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/13636 |
ms-zhenhua
added
ARMSignedOff
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rkmanda
approved these changes
Aug 15, 2023
Member
|
Regarding the suppression, I do not see any previous API versions in the public repo. Isnt this the first public API being published? And if so, this is a good time for you to align the folder name with the namespace name following the pascal casing guideline. |
Next Steps to Merge |
Member
|
Reconsider changing the folder name to Pascal casing. Once you are done addressing this, you may place the MergeRequested label again for a request to merge |
Contributor
Author
|
Hi @rkmanda, |
Contributor
Author
|
Pascal casing of folder done. @rkmanda |
Contributor
Author
|
/pr RequestMerge |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
@RBANSALMS - Your PR needs to pass required checks before merge (azure-sdk-for-go, in this case). Add the MergeRequested label back after addressing those items. If you get stuck, you can ask for help in the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3a0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%2520Spec%2520Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47. Pinned comments on that channel identify help contacts for the various SDK reviewers. |
Contributor
|
required checks are now passing |
Contributor
Author
|
/pr RequestMerge |
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Base commit of SCOM MI PP 20230707 version * removing older APIs mention from the readme.md file * Removing older APIs version refs from readme files * Renaming Microsoft.SCOM to Microsoft.Scom * Renaming Microsoft.SCOM to Microsoft.Scom 2 * go sdk error fix --------- Co-authored-by: RBANSALMS <rbansal@microsoft.com> Co-authored-by: Akshansh Sharma <akssharm@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Getting help
and https://aka.ms/ci-fix.