Closed
Conversation
ckairen
added
the
Central-EngSys
Swagger Validation Report
|
|
Hi, @ckairen! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
ckairen
requested review from
konrad-jamrozik,
mikeharder and
weshaggard
as code owners
mikeharder
requested changes
Jul 25, 2023
Member
mikeharder
left a comment
mikeharder
left a comment
There was a problem hiding this comment.
I'm not sure if this addresses all the concerns in the issue. It ensures the last word after the dot is capitalized, but what if there is no dot in the folder name? What if the folder is named something like Foo.Bar where Bar is not a valid suffix?
mikeharder
requested changes
Jul 26, 2023
Member
mikeharder
left a comment
mikeharder
left a comment
There was a problem hiding this comment.
Please delay this PR until #24983 is addressed.
weshaggard
reviewed
Jul 26, 2023
| "Please rename the folder " + | ||
| leafDir + | ||
| " to " + | ||
| leafDir.replace(/\.\w/g, (l) => l.toUpperCase()) |
Member
There was a problem hiding this comment.
Won't this also cause any other of the same letters to be upper cased in the path?
Member
There was a problem hiding this comment.
@weshaggard: I converted this PR back to draft. It will have significant changes before merging.
Contributor
Author
|
combining with #25712 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #24984