Skip to content

Fixing the DSC resource definitions#2496

Merged
lmazuel merged 1 commit intoAzure:masterfrom
vrdmr:vameru-fix-dsc-azure-resources
Feb 15, 2018
Merged

Fixing the DSC resource definitions#2496
lmazuel merged 1 commit intoAzure:masterfrom
vrdmr:vameru-fix-dsc-azure-resources

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Feb 14, 2018

Both the resources are proxy resources and send all the Proxy Resource properties in the service. This change is to reflect the state of the service.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@vrdmr vrdmr changed the title Fixing the resource definitions Fixing the DSC resource definitions Feb 14, 2018
@AutorestCI
Copy link

AutorestCI commented Feb 14, 2018

Automation for azure-sdk-for-go

Was unable to create SDK azure-sdk-for-go PR for this closed PR.

@AutorestCI
Copy link

AutorestCI commented Feb 14, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#1983

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard this approval...

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 24
After the PR: Warning(s): 0 Error(s): 27

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate properties

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If adding proxyResource, please remove "name" and "id" (duplicate)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I'll remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If adding proxyResource, please remove "name" and "id" (duplicate)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 24
After the PR: Warning(s): 0 Error(s): 27

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@lmazuel
Copy link
Member

lmazuel commented Feb 15, 2018

There is still linter issues, but I feel like the purpose of this specific PR is fine. Try to merge this as atomic improvement to the spec.

@lmazuel lmazuel merged commit 58e3c91 into Azure:master Feb 15, 2018
@vrdmr
Copy link
Member Author

vrdmr commented Feb 15, 2018

Thanks @lmazuel - We are in the process of fixing the Linter issues and would get them down to 0 soon.

@vrdmr vrdmr deleted the vameru-fix-dsc-azure-resources branch February 15, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants