[Hub Generated] Review request for Microsoft.DataReplication to add version preview/2021-02-16-preview#24903
Conversation
|
Hi, @minhsuanlee! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2021-02-16-preview | package-2021-02-16-preview(5ef4eea) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L135 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L205 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L758 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L834 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L896 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L1192 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L1262 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L1519 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L1595 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L1735 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L2067 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L2137 |
|
OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.DataReplication/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L2349 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L2536 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L2612 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L2674 |
|
| The API version:2021-02-16-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L6 |
||
| Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L24 |
||
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L24 |
||
| Not using the common-types defined parameter 'api-version'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L24 |
||
| Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L84 |
||
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L84 |
||
| Not using the common-types defined parameter 'api-version'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L84 |
||
| Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L159 |
||
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L159 |
||
| Not using the common-types defined parameter 'api-version'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L159 |
||
| Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L231 |
||
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L231 |
||
| Not using the common-types defined parameter 'api-version'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L231 |
||
| Not using the common-types defined parameter 'operationId'. Location: Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json#L285 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️All merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @minhsuanlee This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP. |
|
Hi, @minhsuanlee, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
Link to New RP Namespace Issue: https://github.com/Azure/azure-sdk-pr/issues/1220 |
|
@rkmanda I assigned you as @minhsuanlee was asking me for help with LintDiff failures. I also added |
|
Hi @minhsuanlee! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
|
For LintDiff errors LroErrorContent and OperationsApiResponseSchema, I have taken necessary steps to locally reproduce the errors but from what I can tell, the cause of the error does not seem to be valid as our schema is already following the guidelines. I even tried copy-paste the schema from types.json to our swagger directly and re-run Lint validation, it still failed. |
|
@mayada83 if you confirm the |
|
Moving to a new PR [Hub Generated] Review request for Microsoft.DataReplication to add version preview/2021-02-16-preview #24974 as Service Name has been updated from 'azuresiterecovery' to 'recoveryservicesdatareplication' |
Observed that your new RP is not RPaaS based RP. Non-RPaaS RPs are not allowed, unless you have got an exception. If that's the case, please forward me the RPaaS exception email/communication for your RP. Refers to: specification/azuresiterecovery/resource-manager/Microsoft.DataReplication/preview/2021-02-16-preview/azuresiterecovery.json:1 in 5ef4eea. [](commit_id = 5ef4eea, deletion_comment = False) |
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi, @minhsuanlee. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReviewlabel.ARMReviewlabel, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.